[Security] PassportInterface deprecations fixes

Author: wouterj

Security/LdapAuthenticator.php

@@ -72,7 +72,7 @@ public function createAuthenticatedToken(PassportInterface $passport, string $fi
         return $this->createToken($passport, $firewallName);
     }
 
-    public function createToken(PassportInterface $passport, string $firewallName): TokenInterface
+    public function createToken(Passport $passport, string $firewallName): TokenInterface
     {
         // @deprecated since Symfony 5.4, in 6.0 change to:
         // return $this->authenticator->createToken($passport, $firewallName);

Tests/Security/CheckLdapCredentialsListenerTest.php

@@ -116,12 +116,23 @@ public function provideWrongPassportData()
 
         // no password credentials
         yield [new SelfValidatingPassport(new UserBadge('test'), [new LdapBadge('app.ldap')])];
+    }
+
+    /**
+     * @group legacy
+     */
+    public function testLegacyWrongPassport()
+    {
+        $this->expectException(\LogicException::class);
+        $this->expectExceptionMessage('LDAP authentication requires a passport containing a user and password credentials, authenticator "'.TestAuthenticator::class.'" does not fulfill these requirements.');
 
         // no user passport
         $passport = $this->createMock(PassportInterface::class);
         $passport->expects($this->any())->method('hasBadge')->with(LdapBadge::class)->willReturn(true);
         $passport->expects($this->any())->method('getBadge')->with(LdapBadge::class)->willReturn(new LdapBadge('app.ldap'));
-        yield [$passport];
+
+        $listener = $this->createListener();
+        $listener->onCheckPassport(new CheckPassportEvent(new TestAuthenticator(), $passport));
     }
 
     public function testEmptyPasswordShouldThrowAnException()