Leverage non-capturing catches

Author: fancyweb

Security/CheckLdapCredentialsListener.php

@@ -77,7 +77,7 @@ public function onCheckPassport(CheckPassportEvent $event)
                 if ('' !== $ldapBadge->getSearchDn() && '' !== $ldapBadge->getSearchPassword()) {
                     try {
                         $ldap->bind($ldapBadge->getSearchDn(), $ldapBadge->getSearchPassword());
-                    } catch (InvalidCredentialsException $e) {
+                    } catch (InvalidCredentialsException) {
                         throw new InvalidSearchCredentialsException();
                     }
                 } else {
@@ -97,7 +97,7 @@ public function onCheckPassport(CheckPassportEvent $event)
             }
 
             $ldap->bind($dn, $presentedPassword);
-        } catch (InvalidCredentialsException $e) {
+        } catch (InvalidCredentialsException) {
             throw new BadCredentialsException('The presented password is invalid.');
         }
 

Security/LdapUserProvider.php

@@ -76,7 +76,7 @@ public function loadUserByIdentifier(string $identifier): UserInterface
     {
         try {
             $this->ldap->bind($this->searchDn, $this->searchPassword);
-        } catch (InvalidCredentialsException $e) {
+        } catch (InvalidCredentialsException) {
             throw new InvalidSearchCredentialsException();
         }
 
@@ -107,7 +107,7 @@ public function loadUserByIdentifier(string $identifier): UserInterface
             if (null !== $this->uidKey) {
                 $identifier = $this->getAttributeValue($entry, $this->uidKey);
             }
-        } catch (InvalidArgumentException $e) {
+        } catch (InvalidArgumentException) {
         }
 
         return $this->loadUser($identifier, $entry);
@@ -144,7 +144,7 @@ public function upgradePassword(PasswordAuthenticatedUserInterface $user, string
             $user->getEntry()->setAttribute($this->passwordAttribute, [$newHashedPassword]);
             $this->ldap->getEntryManager()->update($user->getEntry());
             $user->setPassword($newHashedPassword);
-        } catch (ExceptionInterface $e) {
+        } catch (ExceptionInterface) {
             // ignore failed password upgrades
         }
     }