Merge branch '5.3' into 5.4

* 5.3:
  [Ldap] Avoid calling the deprecated getUsername()
  Report the correct package in the deprecation message
  Wrapping exception js in Sfjs check and also loading base_js Sfjs if needed
  Fix PHP 8.1 deprecations
  Add missing deprecation entry
  [VarDumper] Don't pass null to parse_url()
  Invalid copy-paste fix

Author: derrabus

Security/LdapUser.php

@@ -76,7 +76,7 @@ public function getSalt(): ?string
      */
     public function getUsername(): string
     {
-        trigger_deprecation('symfony/security-core', '5.3', 'Method "%s()" is deprecated and will be removed in 6.0, use getUserIdentifier() instead.', __METHOD__);
+        trigger_deprecation('symfony/ldap', '5.3', 'Method "%s()" is deprecated and will be removed in 6.0, use getUserIdentifier() instead.', __METHOD__);
 
         return $this->username;
     }
@@ -121,7 +121,7 @@ public function isEqualTo(UserInterface $user): bool
             return false;
         }
 
-        if ($this->getUsername() !== $user->getUsername()) {
+        if ($this->getUserIdentifier() !== $user->getUserIdentifier()) {
             return false;
         }
 

Tests/Security/CheckLdapCredentialsListenerTest.php

@@ -138,6 +138,7 @@ public function testBindFailureShouldThrowAnException()
         $this->expectException(BadCredentialsException::class);
         $this->expectExceptionMessage('The presented password is invalid.');
 
+        $this->ldap->method('escape')->willReturnArgument(0);
         $this->ldap->expects($this->any())->method('bind')->willThrowException(new ConnectionException());
 
         $listener = $this->createListener();
@@ -178,6 +179,7 @@ public function testEmptyQueryResultShouldThrowAnException()
             ->withConsecutive(
                 ['elsa', 'test1234A$']
             );
+        $this->ldap->method('escape')->willReturnArgument(0);
         $this->ldap->expects($this->once())->method('query')->willReturn($query);
 
         $listener = $this->createListener();