Add return types, round 1

Author: nicolas-grekas

Data/Bundle/Reader/BufferedBundleReader.php

@@ -23,11 +23,6 @@ class BufferedBundleReader implements BundleReaderInterface
     private $reader;
     private $buffer;
 
-    /**
-     * Buffers a given reader.
-     *
-     * @param int $bufferSize The number of entries to store in the buffer
-     */
     public function __construct(BundleReaderInterface $reader, int $bufferSize)
     {
         $this->reader = $reader;
@@ -37,7 +32,7 @@ public function __construct(BundleReaderInterface $reader, int $bufferSize)
     /**
      * {@inheritdoc}
      */
-    public function read(string $path, string $locale)
+    public function read(string $path, string $locale): mixed
     {
         $hash = $path.'//'.$locale;
 

Data/Bundle/Reader/BundleEntryReader.php

@@ -61,15 +61,15 @@ public function setLocaleAliases(array $localeAliases)
     /**
      * {@inheritdoc}
      */
-    public function read(string $path, string $locale)
+    public function read(string $path, string $locale): mixed
     {
         return $this->reader->read($path, $locale);
     }
 
     /**
      * {@inheritdoc}
      */
-    public function readEntry(string $path, string $locale, array $indices, bool $fallback = true)
+    public function readEntry(string $path, string $locale, array $indices, bool $fallback = true): mixed
     {
         $entry = null;
         $isMultiValued = false;

Data/Bundle/Reader/IntlBundleReader.php

@@ -26,7 +26,7 @@ class IntlBundleReader implements BundleReaderInterface
     /**
      * {@inheritdoc}
      */
-    public function read(string $path, string $locale)
+    public function read(string $path, string $locale): mixed
     {
         // Point for future extension: Modify this class so that it works also
         // if the \ResourceBundle class is not available.

Data/Bundle/Reader/JsonBundleReader.php

@@ -26,7 +26,7 @@ class JsonBundleReader implements BundleReaderInterface
     /**
      * {@inheritdoc}
      */
-    public function read(string $path, string $locale)
+    public function read(string $path, string $locale): mixed
     {
         $fileName = $path.'/'.$locale.'.json';
 

Data/Bundle/Reader/PhpBundleReader.php

@@ -25,7 +25,7 @@ class PhpBundleReader implements BundleReaderInterface
     /**
      * {@inheritdoc}
      */
-    public function read(string $path, string $locale)
+    public function read(string $path, string $locale): mixed
     {
         $fileName = $path.'/'.$locale.'.php';
 

ResourceBundle.php

@@ -43,7 +43,7 @@ abstract protected static function getPath(): string;
      * @return mixed returns an array or {@link \ArrayAccess} instance for
      *               complex data and a scalar value for simple data
      */
-    final protected static function readEntry(array $indices, string $locale = null, bool $fallback = true)
+    final protected static function readEntry(array $indices, string $locale = null, bool $fallback = true): mixed
     {
         if (null === self::$entryReader) {
             self::$entryReader = new BundleEntryReader(new BufferedBundleReader(