use constructor property promotion

Author: xabbuh

Data/Bundle/Reader/BufferedBundleReader.php

@@ -20,13 +20,13 @@
  */
 class BufferedBundleReader implements BundleReaderInterface
 {
-    private BundleReaderInterface $reader;
     /** @var RingBuffer<string, mixed> */
     private RingBuffer $buffer;
 
-    public function __construct(BundleReaderInterface $reader, int $bufferSize)
-    {
-        $this->reader = $reader;
+    public function __construct(
+        private BundleReaderInterface $reader,
+        int $bufferSize,
+    ) {
         $this->buffer = new RingBuffer($bufferSize);
     }
 

Data/Bundle/Reader/BundleEntryReader.php

@@ -28,8 +28,6 @@
  */
 class BundleEntryReader implements BundleEntryReaderInterface
 {
-    private BundleReaderInterface $reader;
-
     /**
      * A mapping of locale aliases to locales.
      */
@@ -38,9 +36,9 @@ class BundleEntryReader implements BundleEntryReaderInterface
     /**
      * Creates an entry reader based on the given resource bundle reader.
      */
-    public function __construct(BundleReaderInterface $reader)
-    {
-        $this->reader = $reader;
+    public function __construct(
+        private BundleReaderInterface $reader,
+    ) {
     }
 
     /**

Data/Generator/AbstractDataGenerator.php

@@ -27,13 +27,10 @@
  */
 abstract class AbstractDataGenerator
 {
-    private BundleCompilerInterface $compiler;
-    private string $dirName;
-
-    public function __construct(BundleCompilerInterface $compiler, string $dirName)
-    {
-        $this->compiler = $compiler;
-        $this->dirName = $dirName;
+    public function __construct(
+        private BundleCompilerInterface $compiler,
+        private string $dirName,
+    ) {
     }
 
     public function generateData(GeneratorConfig $config): void

Data/Generator/GeneratorConfig.php

@@ -22,18 +22,15 @@
  */
 class GeneratorConfig
 {
-    private string $sourceDir;
-    private string $icuVersion;
-
     /**
      * @var BundleWriterInterface[]
      */
     private array $bundleWriters = [];
 
-    public function __construct(string $sourceDir, string $icuVersion)
-    {
-        $this->sourceDir = $sourceDir;
-        $this->icuVersion = $icuVersion;
+    public function __construct(
+        private string $sourceDir,
+        private string $icuVersion,
+    ) {
     }
 
     /**

Data/Util/ArrayAccessibleResourceBundle.php

@@ -25,11 +25,9 @@
  */
 class ArrayAccessibleResourceBundle implements \ArrayAccess, \IteratorAggregate, \Countable
 {
-    private \ResourceBundle $bundleImpl;
-
-    public function __construct(\ResourceBundle $bundleImpl)
-    {
-        $this->bundleImpl = $bundleImpl;
+    public function __construct(
+        private \ResourceBundle $bundleImpl,
+    ) {
     }
 
     public function get(int|string $offset): mixed

Data/Util/RingBuffer.php

@@ -36,11 +36,10 @@ class RingBuffer implements \ArrayAccess
     /** @var array<TKey, int> */
     private array $indices = [];
     private int $cursor = 0;
-    private int $size;
 
-    public function __construct(int $size)
-    {
-        $this->size = $size;
+    public function __construct(
+        private int $size,
+    ) {
     }
 
     public function offsetExists(mixed $key): bool

Util/GitRepository.php

@@ -19,12 +19,9 @@
  */
 final class GitRepository
 {
-    private string $path;
-
-    public function __construct(string $path)
-    {
-        $this->path = $path;
-
+    public function __construct(
+        private string $path,
+    ) {
         $this->getUrl();
     }