Skip to content

Commit 385d5ac

Browse files
Remove unused code and unnecessary else branches
1 parent f526c09 commit 385d5ac

File tree

3 files changed

+4
-12
lines changed

3 files changed

+4
-12
lines changed

Data/Generator/CurrencyDataGenerator.php

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -115,9 +115,7 @@ private function generateSymbolNamePairs(ArrayAccessibleResourceBundle $rootBund
115115
$symbolNamePairs = array_map(fn ($pair) => \array_slice(iterator_to_array($pair), 0, 2), iterator_to_array($rootBundle['Currencies']));
116116

117117
// Remove unwanted currencies
118-
$symbolNamePairs = array_diff_key($symbolNamePairs, self::DENYLIST);
119-
120-
return $symbolNamePairs;
118+
return array_diff_key($symbolNamePairs, self::DENYLIST);
121119
}
122120

123121
private function generateCurrencyMeta(ArrayAccessibleResourceBundle $supplementalDataBundle): array
@@ -134,9 +132,7 @@ private function generateAlpha3ToNumericMapping(ArrayAccessibleResourceBundle $n
134132
asort($alpha3ToNumericMapping);
135133

136134
// Filter unknown currencies (e.g. "AYM")
137-
$alpha3ToNumericMapping = array_intersect_key($alpha3ToNumericMapping, array_flip($currencyCodes));
138-
139-
return $alpha3ToNumericMapping;
135+
return array_intersect_key($alpha3ToNumericMapping, array_flip($currencyCodes));
140136
}
141137

142138
private function generateNumericToAlpha3Mapping(array $alpha3ToNumericMapping): array

Data/Generator/LanguageDataGenerator.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -130,12 +130,10 @@ protected function generateDataForLocale(BundleEntryReaderInterface $reader, str
130130
$localizedNames[$language] = $name;
131131
}
132132
}
133-
$data = [
133+
return [
134134
'Names' => $names,
135135
'LocalizedNames' => $localizedNames,
136136
];
137-
138-
return $data;
139137
}
140138

141139
return null;

Data/Generator/TimezoneDataGenerator.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,13 +128,11 @@ protected function generateDataForMeta(BundleEntryReaderInterface $reader, strin
128128
sort($this->zoneIds);
129129
ksort($this->zoneToCountryMapping);
130130

131-
$data = [
131+
return [
132132
'Zones' => $this->zoneIds,
133133
'ZoneToCountry' => $this->zoneToCountryMapping,
134134
'CountryToZone' => self::generateCountryToZoneMapping($this->zoneToCountryMapping),
135135
];
136-
137-
return $data;
138136
}
139137

140138
private function generateZones(BundleEntryReaderInterface $reader, string $tempDir, string $locale): array

0 commit comments

Comments
 (0)