Add return type unions to private/internal/final/test methods

Author: nicolas-grekas

DataCollector/MemoryDataCollector.php

@@ -79,10 +79,7 @@ public function getName(): string
         return 'memory';
     }
 
-    /**
-     * @return int|float
-     */
-    private function convertToBytes(string $memoryLimit)
+    private function convertToBytes(string $memoryLimit): int|float
     {
         if ('-1' === $memoryLimit) {
             return -1;

EventListener/DebugHandlersListener.php

@@ -28,7 +28,7 @@
  *
  * @final
  *
- * @internal since Symfony 5.3
+ * @internal
  */
 class DebugHandlersListener implements EventSubscriberInterface
 {

Tests/HttpCache/TestHttpKernel.php

@@ -67,7 +67,7 @@ public function isCatchingExceptions()
         return $this->catch;
     }
 
-    public function getController(Request $request)
+    public function getController(Request $request): callable|false
     {
         return [$this, 'callController'];
     }

Tests/HttpCache/TestMultipleHttpKernel.php

@@ -50,7 +50,7 @@ public function handle(Request $request, $type = HttpKernelInterface::MAIN_REQUE
         return parent::handle($request, $type, $catch);
     }
 
-    public function getController(Request $request)
+    public function getController(Request $request): callable|false
     {
         return [$this, 'callController'];
     }

Tests/KernelTest.php

@@ -521,7 +521,7 @@ public function getNamespace()
                 return '';
             }
 
-            public function getXsdValidationBasePath()
+            public function getXsdValidationBasePath(): string|false
             {
                 return false;
             }

Tests/TestHttpKernel.php

@@ -25,7 +25,7 @@ public function __construct()
         parent::__construct(new EventDispatcher(), $this, null, $this);
     }
 
-    public function getController(Request $request)
+    public function getController(Request $request): callable|false
     {
         return [$this, 'callController'];
     }