Skip to content

Commit f5e3e4f

Browse files
committed
bug #45351 [WebProfilerBundle] Log section minor fixes (missing "notice" filter, log priority, accessibility) (Amunak)
This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [WebProfilerBundle] Log section minor fixes (missing "notice" filter, log priority, accessibility) | Q | A | ------------- | --- | Branch? | 5.4 <!-- see below --> | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #42195 (related) | License | MIT | Doc PR | ~ This fixes minor front-end issues with the redesigned Log section in WebProfilerBundle. Marking as bugfix, since technically the redesign removed some features without documenting it - the log level is now visible even for low level logs (debug, notice, info). I have also added the missing "notice" filter and made sure that when a filter is missing the message is shown (fail-safe). I have also implemented accessibility fixes mentioned in the original PR (#42195) by @stof. I did not add tests because I have no idea where or how - currently the profiler front-end is not tested (or at least the log section). These changes do not affect the logic behind the panel in a way that could be easily tested. Screenshot of the changes: notice the visible log levels and added "notice" filter: ![Screenshot of the changes](https://user-images.githubusercontent.com/781546/152992378-89452512-7b94-40b7-9d8e-8f94acc4d058.png) Commits ------- 1c3b2661cf [WebProfilerBundle] Log section minor fixes (missing "notice" filter, log priority, accessibility)
2 parents 9c92c00 + 857c980 commit f5e3e4f

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

DataCollector/LoggerDataCollector.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,7 @@ public function getFilters()
133133
'priority' => [
134134
'Debug' => 100,
135135
'Info' => 200,
136+
'Notice' => 250,
136137
'Warning' => 300,
137138
'Error' => 400,
138139
'Critical' => 500,

0 commit comments

Comments
 (0)