[HttpKernel] allow ignoring kernel.reset methods that don't exist

Author: nicolas-grekas

CHANGELOG.md

@@ -8,6 +8,7 @@ CHANGELOG
  * Deprecate `AbstractTestSessionListener::getSession` inject a session in the request instead
  * Deprecate the `fileLinkFormat` parameter of `DebugHandlersListener`
  * Add support for configuring log level, and status code by exception class
+ * Allow ignoring "kernel.reset" methods that don't exist with "on_invalid" attribute
 
 5.3
 ---

DependencyInjection/ResettableServicePass.php

@@ -57,6 +57,10 @@ public function process(ContainerBuilder $container)
                     $methods[$id] = [];
                 }
 
+                if ('ignore' === ($attributes['on_invalid'] ?? null)) {
+                    $attributes['method'] = '?'.$attributes['method'];
+                }
+
                 $methods[$id][] = $attributes['method'];
             }
         }

DependencyInjection/ServicesResetter.php

@@ -40,6 +40,10 @@ public function reset()
     {
         foreach ($this->resettableServices as $id => $service) {
             foreach ((array) $this->resetMethods[$id] as $resetMethod) {
+                if ('?' === $resetMethod[0] && !method_exists($service, $resetMethod = substr($resetMethod, 1))) {
+                    continue;
+                }
+
                 $service->$resetMethod();
             }
         }

Tests/DependencyInjection/ResettableServicePassTest.php

@@ -70,6 +70,26 @@ public function testMissingMethod()
         $container->compile();
     }
 
+    public function testIgnoreInvalidMethod()
+    {
+        $container = new ContainerBuilder();
+        $container->register(ResettableService::class)
+            ->setPublic(true)
+            ->addTag('kernel.reset', ['method' => 'missingMethod', 'on_invalid' => 'ignore']);
+        $container->register('services_resetter', ServicesResetter::class)
+            ->setPublic(true)
+            ->setArguments([null, []]);
+        $container->addCompilerPass(new ResettableServicePass());
+
+        $container->compile();
+
+        $this->assertSame([ResettableService::class => ['?missingMethod']], $container->getDefinition('services_resetter')->getArgument(1));
+
+        $resettable = $container->get(ResettableService::class);
+        $resetter = $container->get('services_resetter');
+        $resetter->reset();
+    }
+
     public function testCompilerPassWithoutResetters()
     {
         $container = new ContainerBuilder();