|
21 | 21 | use Symfony\Component\HttpFoundation\Session\Session;
|
22 | 22 | use Symfony\Component\HttpFoundation\Session\Storage\NativeSessionStorage;
|
23 | 23 | use Symfony\Component\HttpKernel\Event\FinishRequestEvent;
|
| 24 | +use Symfony\Component\HttpKernel\Event\GetResponseEvent; |
24 | 25 | use Symfony\Component\HttpKernel\Event\RequestEvent;
|
25 | 26 | use Symfony\Component\HttpKernel\Event\ResponseEvent;
|
26 | 27 | use Symfony\Component\HttpKernel\EventListener\AbstractSessionListener;
|
27 | 28 | use Symfony\Component\HttpKernel\EventListener\SessionListener;
|
28 | 29 | use Symfony\Component\HttpKernel\Exception\UnexpectedSessionUsageException;
|
29 | 30 | use Symfony\Component\HttpKernel\HttpKernelInterface;
|
| 31 | +use Symfony\Component\HttpKernel\KernelInterface; |
30 | 32 |
|
31 | 33 | class SessionListenerTest extends TestCase
|
32 | 34 | {
|
@@ -181,6 +183,38 @@ public function testSurrogateMasterRequestIsPublic()
|
181 | 183 | $this->assertLessThanOrEqual((new \DateTime('now', new \DateTimeZone('UTC'))), (new \DateTime($response->headers->get('Expires'))));
|
182 | 184 | }
|
183 | 185 |
|
| 186 | + public function testGetSessionIsCalledOnce() |
| 187 | + { |
| 188 | + $session = $this->getMockBuilder(Session::class)->disableOriginalConstructor()->getMock(); |
| 189 | + $sessionStorage = $this->getMockBuilder(NativeSessionStorage::class)->getMock(); |
| 190 | + $kernel = $this->getMockBuilder(KernelInterface::class)->getMock(); |
| 191 | + |
| 192 | + $sessionStorage->expects($this->once()) |
| 193 | + ->method('setOptions') |
| 194 | + ->with(['cookie_secure' => true]); |
| 195 | + |
| 196 | + $requestStack = new RequestStack(); |
| 197 | + $requestStack->push($masterRequest = new Request([], [], [], [], [], ['HTTPS' => 'on'])); |
| 198 | + |
| 199 | + $container = new Container(); |
| 200 | + $container->set('session_storage', $sessionStorage); |
| 201 | + $container->set('session', $session); |
| 202 | + $container->set('request_stack', $requestStack); |
| 203 | + |
| 204 | + $event = new GetResponseEvent($kernel, $masterRequest, HttpKernelInterface::MASTER_REQUEST); |
| 205 | + |
| 206 | + $listener = new SessionListener($container); |
| 207 | + $listener->onKernelRequest($event); |
| 208 | + |
| 209 | + $subRequest = $masterRequest->duplicate(); |
| 210 | + // at this point both master and subrequest have a closure to build the session |
| 211 | + |
| 212 | + $masterRequest->getSession(); |
| 213 | + |
| 214 | + // calling the factory on the subRequest should not trigger a second call to storage->sesOptions() |
| 215 | + $subRequest->getSession(); |
| 216 | + } |
| 217 | + |
184 | 218 | public function testSessionUsageExceptionIfStatelessAndSessionUsed()
|
185 | 219 | {
|
186 | 220 | $session = $this->getMockBuilder(Session::class)->disableOriginalConstructor()->getMock();
|
|
0 commit comments