Migrate to static data providers using rector/rector

Author: OskarStark

Tests/Controller/ContainerControllerResolverTest.php

@@ -149,7 +149,7 @@ public function testInstantiateControllerWhenControllerStartsWithABackslash($con
         $this->assertSame('action', $controller[1]);
     }
 
-    public function getControllers()
+    public static function getControllers()
     {
         return [
             ['\\'.ControllerTestService::class.'::action'],

Tests/Controller/ControllerResolverTest.php

@@ -141,7 +141,7 @@ public function testGetControllerWithStaticController($staticController, $return
         $this->assertSame($returnValue, $controller());
     }
 
-    public function getStaticControllers()
+    public static function getStaticControllers()
     {
         return [
             [TestAbstractController::class.'::staticAction', 'foo'],

Tests/Controller/ErrorControllerTest.php

@@ -36,7 +36,7 @@ public function testInvokeController(Request $request, \Exception $exception, in
         self::assertStringContainsString($content, strtr($response->getContent(), ["\n" => '', '    ' => '']));
     }
 
-    public function getInvokeControllerDataProvider()
+    public static function getInvokeControllerDataProvider()
     {
         yield 'default status code and HTML format' => [
             new Request(),

Tests/DataCollector/LoggerDataCollectorTest.php

@@ -179,7 +179,7 @@ public function testReset()
         $c->reset();
     }
 
-    public function getCollectTestData()
+    public static function getCollectTestData()
     {
         yield 'simple log' => [
             1,

Tests/DataCollector/MemoryDataCollectorTest.php

@@ -37,7 +37,7 @@ public function testBytesConversion($limit, $bytes)
         $this->assertEquals($bytes, $method->invoke($collector, $limit));
     }
 
-    public function getBytesConversionTestData()
+    public static function getBytesConversionTestData()
     {
         return [
             ['2k', 2048],

Tests/DependencyInjection/RegisterControllerArgumentLocatorsPassTest.php

@@ -308,7 +308,7 @@ public function testBindings($bindingName)
         $this->assertEquals($expected, $locator->getArgument(0));
     }
 
-    public function provideBindings()
+    public static function provideBindings()
     {
         return [
             [ControllerDummy::class.'$bar'],
@@ -343,7 +343,7 @@ public function testBindScalarValueToControllerArgument($bindingKey)
         $this->assertSame('foo_val', $locator->get('foo::fooAction')->get('someArg'));
     }
 
-    public function provideBindScalarValueToControllerArgument()
+    public static function provideBindScalarValueToControllerArgument()
     {
         yield ['$someArg'];
         yield ['string $someArg'];

Tests/EventListener/DebugHandlersListenerTest.php

@@ -157,7 +157,7 @@ public function testReplaceExistingExceptionHandler()
         $this->assertSame($userHandler, $eHandler->setExceptionHandler('var_dump'));
     }
 
-    public function provideLevelsAssignedToLoggers(): array
+    public static function provideLevelsAssignedToLoggers(): array
     {
         return [
             [false, false, '0', null, null],

Tests/EventListener/DisallowRobotsIndexingListenerTest.php

@@ -36,7 +36,7 @@ public function testInvoke(?string $expected, array $responseArgs)
         $this->assertSame($expected, $response->headers->get('X-Robots-Tag'), 'Header doesn\'t match expectations');
     }
 
-    public function provideResponses(): iterable
+    public static function provideResponses(): iterable
     {
         yield 'No header' => ['noindex', []];
 

Tests/EventListener/ErrorListenerTest.php

@@ -119,7 +119,7 @@ public function testHandleWithLoggerAndCustomConfiguration()
         $this->assertCount(1, $logger->getLogs('warning'));
     }
 
-    public function provider()
+    public static function provider()
     {
         if (!class_exists(Request::class)) {
             return [[null, null]];
@@ -202,7 +202,7 @@ public function testOnControllerArguments(callable $controller)
         $this->assertSame('OK: foo', $event->getResponse()->getContent());
     }
 
-    public function controllerProvider()
+    public static function controllerProvider()
     {
         yield [function (FlattenException $exception) {
             return new Response('OK: '.$exception->getMessage());

Tests/EventListener/ProfilerListenerTest.php

@@ -87,7 +87,7 @@ public function testCollectParameter(Request $request, ?bool $enable)
         $listener->onKernelResponse(new ResponseEvent($kernel, $request, Kernel::MAIN_REQUEST, $response));
     }
 
-    public function collectRequestProvider(): iterable
+    public static function collectRequestProvider(): iterable
     {
         yield [Request::create('/'), null];
         yield [Request::create('/', 'GET', ['profile' => '1']), true];