Leverage non-capturing catches

Author: fancyweb

Controller/ArgumentResolver/DateTimeValueResolver.php

@@ -68,7 +68,7 @@ public function resolve(Request $request, ArgumentMetadata $argument): iterable
             }
             try {
                 $date = new $class($value);
-            } catch (\Exception $e) {
+            } catch (\Exception) {
                 $date = false;
             }
         }

Controller/ControllerResolver.php

@@ -112,7 +112,7 @@ protected function createController(string $controller): callable
                 if ((new \ReflectionMethod($class, $method))->isStatic()) {
                     return $class.'::'.$method;
                 }
-            } catch (\ReflectionException $reflectionException) {
+            } catch (\ReflectionException) {
                 throw $e;
             }
 

DataCollector/RequestDataCollector.php

@@ -449,7 +449,7 @@ private function parseController(array|object|string|null $controller): array|st
                     'file' => $r->getFileName(),
                     'line' => $r->getStartLine(),
                 ];
-            } catch (\ReflectionException $e) {
+            } catch (\ReflectionException) {
                 if (\is_callable($controller)) {
                     // using __call or  __callStatic
                     return [

Debug/FileLinkFormatter.php

@@ -81,7 +81,7 @@ public static function generateUrlFormat(UrlGeneratorInterface $router, string $
     {
         try {
             return $router->generate($routeName).$queryString;
-        } catch (\Throwable $e) {
+        } catch (\Throwable) {
             return null;
         }
     }

Debug/TraceableEventDispatcher.php

@@ -52,7 +52,7 @@ protected function beforeDispatch(string $eventName, object $event)
                 // which must be caught.
                 try {
                     $this->stopwatch->openSection($sectionId);
-                } catch (\LogicException $e) {
+                } catch (\LogicException) {
                 }
                 break;
         }
@@ -83,7 +83,7 @@ protected function afterDispatch(string $eventName, object $event)
                 }
                 try {
                     $this->stopwatch->stopSection($sectionId);
-                } catch (\LogicException $e) {
+                } catch (\LogicException) {
                 }
                 break;
         }

EventListener/LocaleAwareListener.php

@@ -69,7 +69,7 @@ private function setLocale(string $locale, string $defaultLocale): void
         foreach ($this->localeAwareServices as $service) {
             try {
                 $service->setLocale($locale);
-            } catch (\InvalidArgumentException $e) {
+            } catch (\InvalidArgumentException) {
                 $service->setLocale($defaultLocale);
             }
         }

Exception/ControllerDoesNotReturnResponseException.php

@@ -49,7 +49,7 @@ private function parseControllerDefinition(callable $controller): ?array
                     'file' => $r->getFileName(),
                     'line' => $r->getEndLine(),
                 ];
-            } catch (\ReflectionException $e) {
+            } catch (\ReflectionException) {
                 return null;
             }
         }
@@ -68,7 +68,7 @@ private function parseControllerDefinition(callable $controller): ?array
 
             try {
                 $line = $r->getMethod('__invoke')->getEndLine();
-            } catch (\ReflectionException $e) {
+            } catch (\ReflectionException) {
                 $line = $r->getEndLine();
             }
 

HttpKernel.php

@@ -237,7 +237,7 @@ private function handleThrowable(\Throwable $e, Request $request, int $type): Re
 
         try {
             return $this->filterResponse($response, $request, $type);
-        } catch (\Exception $e) {
+        } catch (\Exception) {
             return $response;
         }
     }

Profiler/Profiler.php

@@ -142,7 +142,7 @@ public function collect(Request $request, Response $response, \Throwable $except
         $profile->setStatusCode($response->getStatusCode());
         try {
             $profile->setIp($request->getClientIp());
-        } catch (ConflictingHeadersException $e) {
+        } catch (ConflictingHeadersException) {
             $profile->setIp('Unknown');
         }
 
@@ -233,7 +233,7 @@ private function getTimestamp(?string $value): ?int
 
         try {
             $value = new \DateTime(is_numeric($value) ? '@'.$value : $value);
-        } catch (\Exception $e) {
+        } catch (\Exception) {
             return null;
         }