Skip to content

Commit 7c4f2d0

Browse files
committed
minor #47390 [CS] Remove @inheritdoc PHPDoc (lyrixx)
This PR was merged into the 6.2 branch. Discussion ---------- [CS] Remove `@inheritdoc` PHPDoc | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | --- It looks like this PHP Doc is useless. IDEs are able to inherit the doc (at least VS Code and PHP Storm). And tools like PHP Stan are able to too https://phpstan.org/r/74a2c008-ff2b-42c0-8edf-8da87c1a7b5f I could have open an RFC before doing the PR, but it was easy :) So let's discuss here Commits ------- 015d5015e3 [CS] Remove `@inheritdoc` PHPDoc
2 parents 9902659 + 3b05051 commit 7c4f2d0

File tree

55 files changed

+0
-324
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+0
-324
lines changed

Bundle/AbstractBundle.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,6 @@ public function getContainerExtension(): ?ExtensionInterface
4848
return $this->extension ??= new BundleExtension($this, $this->extensionAlias);
4949
}
5050

51-
/**
52-
* {@inheritdoc}
53-
*/
5451
public function getPath(): string
5552
{
5653
if (null === $this->path) {

Bundle/Bundle.php

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -31,23 +31,15 @@ abstract class Bundle implements BundleInterface
3131
protected $path;
3232
private string $namespace;
3333

34-
/**
35-
* {@inheritdoc}
36-
*/
3734
public function boot()
3835
{
3936
}
4037

41-
/**
42-
* {@inheritdoc}
43-
*/
4438
public function shutdown()
4539
{
4640
}
4741

4842
/**
49-
* {@inheritdoc}
50-
*
5143
* This method can be overridden to register compilation passes,
5244
* other extensions, ...
5345
*/
@@ -87,9 +79,6 @@ public function getContainerExtension(): ?ExtensionInterface
8779
return $this->extension ?: null;
8880
}
8981

90-
/**
91-
* {@inheritdoc}
92-
*/
9382
public function getNamespace(): string
9483
{
9584
if (!isset($this->namespace)) {
@@ -99,9 +88,6 @@ public function getNamespace(): string
9988
return $this->namespace;
10089
}
10190

102-
/**
103-
* {@inheritdoc}
104-
*/
10591
public function getPath(): string
10692
{
10793
if (null === $this->path) {

CacheClearer/ChainCacheClearer.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,6 @@ public function __construct(iterable $clearers = [])
3030
$this->clearers = $clearers;
3131
}
3232

33-
/**
34-
* {@inheritdoc}
35-
*/
3633
public function clear(string $cacheDir)
3734
{
3835
foreach ($this->clearers as $clearer) {

CacheClearer/Psr6CacheClearer.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,6 @@ public function clearPool(string $name): bool
5757
return $this->pools[$name]->clear();
5858
}
5959

60-
/**
61-
* {@inheritdoc}
62-
*/
6360
public function clear(string $cacheDir)
6461
{
6562
foreach ($this->pools as $pool) {

CacheWarmer/CacheWarmerAggregate.php

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,6 @@ public function enableOnlyOptionalWarmers()
4646
$this->onlyOptionalsEnabled = $this->optionalsEnabled = true;
4747
}
4848

49-
/**
50-
* {@inheritdoc}
51-
*/
5249
public function warmUp(string $cacheDir): array
5350
{
5451
if ($collectDeprecations = $this->debug && !\defined('PHPUNIT_COMPOSER_INSTALL')) {
@@ -116,9 +113,6 @@ public function warmUp(string $cacheDir): array
116113
return array_values(array_unique(array_merge([], ...$preload)));
117114
}
118115

119-
/**
120-
* {@inheritdoc}
121-
*/
122116
public function isOptional(): bool
123117
{
124118
return false;

Config/FileLocator.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,6 @@ public function __construct(KernelInterface $kernel)
3030
parent::__construct();
3131
}
3232

33-
/**
34-
* {@inheritdoc}
35-
*/
3633
public function locate(string $file, string $currentPath = null, bool $first = true): string|array
3734
{
3835
if (isset($file[0]) && '@' === $file[0]) {

Controller/ArgumentResolver.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,6 @@ public function __construct(ArgumentMetadataFactoryInterface $argumentMetadataFa
4040
$this->argumentValueResolvers = $argumentValueResolvers ?: self::getDefaultArgumentValueResolvers();
4141
}
4242

43-
/**
44-
* {@inheritdoc}
45-
*/
4643
public function getArguments(Request $request, callable $controller): array
4744
{
4845
$arguments = [];

Controller/ArgumentResolver/DateTimeValueResolver.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,6 @@ public function supports(Request $request, ArgumentMetadata $argument): bool
3636
return is_a($argument->getType(), \DateTimeInterface::class, true) && $request->attributes->has($argument->getName());
3737
}
3838

39-
/**
40-
* {@inheritdoc}
41-
*/
4239
public function resolve(Request $request, ArgumentMetadata $argument): array
4340
{
4441
if (!is_a($argument->getType(), \DateTimeInterface::class, true) || !$request->attributes->has($argument->getName())) {

Controller/ArgumentResolver/DefaultValueResolver.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,6 @@ public function supports(Request $request, ArgumentMetadata $argument): bool
3333
return $argument->hasDefaultValue() || (null !== $argument->getType() && $argument->isNullable() && !$argument->isVariadic());
3434
}
3535

36-
/**
37-
* {@inheritdoc}
38-
*/
3936
public function resolve(Request $request, ArgumentMetadata $argument): array
4037
{
4138
if ($argument->hasDefaultValue()) {

Controller/ArgumentResolver/NotTaggedControllerValueResolver.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,6 @@ public function supports(Request $request, ArgumentMetadata $argument): bool
5858
return false === $this->container->has($controller);
5959
}
6060

61-
/**
62-
* {@inheritdoc}
63-
*/
6461
public function resolve(Request $request, ArgumentMetadata $argument): array
6562
{
6663
$controller = $request->attributes->get('_controller');

0 commit comments

Comments
 (0)