Move array_merge calls out of loops to improve performance

simonberger · simonberger · commit 757799933181 · 2021-10-04T20:34:22.000+02:00
diff --git a/DependencyInjection/AddAnnotatedClassesToCachePass.php b/DependencyInjection/AddAnnotatedClassesToCachePass.php
@@ -37,13 +37,15 @@ public function __construct(Kernel $kernel)
      */
     public function process(ContainerBuilder $container)
     {
-        $annotatedClasses = $this->kernel->getAnnotatedClassesToCompile();
+        $annotatedClasses = [];
         foreach ($container->getExtensions() as $extension) {
             if ($extension instanceof Extension) {
-                $annotatedClasses = array_merge($annotatedClasses, $extension->getAnnotatedClassesToCompile());
+                $annotatedClasses[] = $extension->getAnnotatedClassesToCompile();
             }
         }
 
+        $annotatedClasses = array_merge($this->kernel->getAnnotatedClassesToCompile(), ...$annotatedClasses);
+
         $existingClasses = $this->getClassesInComposerClassMaps();
 
         $annotatedClasses = $container->getParameterBag()->resolveValue($annotatedClasses);

Original file line number	Diff line number	Diff line change
`@@ -37,13 +37,15 @@ public function __construct(Kernel $kernel)`
`37`	`37`	`*/`
`38`	`38`	`public function process(ContainerBuilder $container)`
`39`	`39`	`{`
`40`		`- $annotatedClasses = $this->kernel->getAnnotatedClassesToCompile();`
	`40`	`+ $annotatedClasses = [];`
`41`	`41`	`foreach ($container->getExtensions() as $extension) {`
`42`	`42`	`if ($extension instanceof Extension) {`
`43`		`- $annotatedClasses = array_merge($annotatedClasses, $extension->getAnnotatedClassesToCompile());`
	`43`	`+ $annotatedClasses[] = $extension->getAnnotatedClassesToCompile();`
`44`	`44`	`}`
`45`	`45`	`}`
`46`	`46`
	`47`	`+ $annotatedClasses = array_merge($this->kernel->getAnnotatedClassesToCompile(), ...$annotatedClasses);`
	`48`	`+`
`47`	`49`	`$existingClasses = $this->getClassesInComposerClassMaps();`
`48`	`50`
`49`	`51`	`$annotatedClasses = $container->getParameterBag()->resolveValue($annotatedClasses);`