feature #37537 [HttpKernel] Provide status code in fragment handler exception (gonzalovilaseca)

This PR was merged into the 5.2-dev branch.

Discussion
----------

[HttpKernel] Provide status code in fragment handler exception

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

We have a use case where it would be useful to retrieve the status code in an exception listener from the exception thrown by the fragment handler, current solution is to extract it from the exception string which is ugly.
With this change we can get the status code from the exception directly.

Commits
-------

81ca1f00a3 [HttpKernel] Provide status code in fragment handler exception

Author: fabpot

Fragment/FragmentHandler.php

@@ -15,6 +15,7 @@
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpFoundation\StreamedResponse;
 use Symfony\Component\HttpKernel\Controller\ControllerReference;
+use Symfony\Component\HttpKernel\Exception\HttpException;
 
 /**
  * Renders a URI that represents a resource fragment.
@@ -97,7 +98,8 @@ public function render($uri, string $renderer = 'inline', array $options = [])
     protected function deliver(Response $response)
     {
         if (!$response->isSuccessful()) {
-            throw new \RuntimeException(sprintf('Error when rendering "%s" (Status code is %d).', $this->requestStack->getCurrentRequest()->getUri(), $response->getStatusCode()));
+            $responseStatusCode = $response->getStatusCode();
+            throw new \RuntimeException(sprintf('Error when rendering "%s" (Status code is %d).', $this->requestStack->getCurrentRequest()->getUri(), $responseStatusCode), 0, new HttpException($responseStatusCode));
         }
 
         if (!$response instanceof StreamedResponse) {

Tests/Fragment/FragmentHandlerTest.php

@@ -14,6 +14,7 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\HttpKernel\Exception\HttpException;
 use Symfony\Component\HttpKernel\Fragment\FragmentHandler;
 
 /**
@@ -53,11 +54,20 @@ public function testRenderWithUnknownRenderer()
 
     public function testDeliverWithUnsuccessfulResponse()
     {
-        $this->expectException('RuntimeException');
-        $this->expectExceptionMessage('Error when rendering "http://localhost/" (Status code is 404).');
         $handler = $this->getHandler($this->returnValue(new Response('foo', 404)));
-
-        $handler->render('/', 'foo');
+        try {
+            $handler->render('/', 'foo');
+            $this->fail('->render() throws a \RuntimeException exception if response is not successful');
+        } catch (\Exception $e) {
+            $this->assertInstanceOf('\RuntimeException', $e);
+            $this->assertEquals(0, $e->getCode());
+            $this->assertEquals('Error when rendering "http://localhost/" (Status code is 404).', $e->getMessage());
+
+            $previousException = $e->getPrevious();
+            $this->assertInstanceOf(HttpException::class, $previousException);
+            $this->assertEquals(404, $previousException->getStatusCode());
+            $this->assertEquals(0, $previousException->getCode());
+        }
     }
 
     public function testRender()