Merge branch '6.1' into 6.2

* 6.1:
  prevent the installation of unstable phpdocumentor/type-resolver releases
  chore: fix typo 'do' verb
  [Twig Bridge] Add PHPdoc information to some email methods
  Amend MoneyType twig to include a space.
  Convert previously defined date attribute to the expected class
  [WebProfilerBundle] Remove redundant code from logger template

Author: xabbuh

Controller/ArgumentResolver/DateTimeValueResolver.php

@@ -43,16 +43,16 @@ public function resolve(Request $request, ArgumentMetadata $argument): array
         }
 
         $value = $request->attributes->get($argument->getName());
+        $class = \DateTimeInterface::class === $argument->getType() ? \DateTimeImmutable::class : $argument->getType();
 
         if ($value instanceof \DateTimeInterface) {
-            return [$value];
+            return [$value instanceof $class ? $value : $class::createFromInterface($value)];
         }
 
         if ($argument->isNullable() && !$value) {
             return [null];
         }
 
-        $class = \DateTimeInterface::class === $argument->getType() ? \DateTimeImmutable::class : $argument->getType();
         $format = null;
 
         if ($attributes = $argument->getAttributes(MapDateTime::class, ArgumentMetadata::IS_INSTANCEOF)) {

Tests/Controller/ArgumentResolver/DateTimeValueResolverTest.php

@@ -20,7 +20,7 @@
 
 class DateTimeValueResolverTest extends TestCase
 {
-    private $defaultTimezone;
+    private readonly string $defaultTimezone;
 
     protected function setUp(): void
     {
@@ -32,13 +32,20 @@ protected function tearDown(): void
         date_default_timezone_set($this->defaultTimezone);
     }
 
-    public function getTimeZones()
+    public static function getTimeZones()
     {
         yield ['UTC'];
         yield ['Etc/GMT+9'];
         yield ['Etc/GMT-14'];
     }
 
+    public static function getClasses()
+    {
+        yield [\DateTimeInterface::class];
+        yield [\DateTime::class];
+        yield [FooDateTime::class];
+    }
+
     /**
      * @group legacy
      */
@@ -137,17 +144,23 @@ public function testNow(string $timezone)
         $this->assertSame($timezone, $results[0]->getTimezone()->getName(), 'Default timezone');
     }
 
-    public function testPreviouslyConvertedAttribute()
+    /**
+     * @param class-string<\DateTimeInterface> $class
+     *
+     * @dataProvider getClasses
+     */
+    public function testPreviouslyConvertedAttribute(string $class)
     {
         $resolver = new DateTimeValueResolver();
 
-        $argument = new ArgumentMetadata('dummy', \DateTimeImmutable::class, false, false, null, true);
+        $argument = new ArgumentMetadata('dummy', $class, false, false, null, true);
         $request = self::requestWithAttributes(['dummy' => $datetime = new \DateTimeImmutable()]);
 
         $results = $resolver->resolve($request, $argument);
 
         $this->assertCount(1, $results);
-        $this->assertSame($datetime, $results[0]);
+        $this->assertEquals($datetime, $results[0], 'The value is the same, but the class can be modified.');
+        $this->assertInstanceOf($class, $results[0]);
     }
 
     public function testCustomClass()
@@ -205,7 +218,7 @@ public function testWithFormat(string $timezone)
         $this->assertEquals('2016-09-08 12:34:56', $results[0]->format('Y-m-d H:i:s'));
     }
 
-    public function provideInvalidDates()
+    public static function provideInvalidDates()
     {
         return [
             'invalid date' => [