Skip to content

Commit 734bfd2

Browse files
committed
Merge branch '2.6' into 2.7
* 2.6: Php Inspections (EA Extended): squash all PR-13813 commits replaced the last remaining is_integer() call [2.3] [Config] [Console] [DependencyInjection] [DomCrawler] [Form] [HttpKernel] [PropertyAccess] [Security] [Translation] [Yaml] static code analysis, code cleanup [FrameworkBundle] simplify dep declaration [VarDumper] Fix "next element is already occupied" [Validator] Added missing galician (gl) translations [PropertyAccess] stop overwriting once a reference is reached (3rd) [OptionsResolver] Remove Unused Variable from Foreach Cycles [travis] Tests Security sub-components [Twig] bootstrap_3_layout.html.twig is usable as a trait [travis] Tests Security sub-components CS fixes [TwigBridge] Bootstrap Layout - Fix the label of checkbox cannot be empty [travis] test with php nightly Conflicts: .travis.yml src/Symfony/Bundle/FrameworkBundle/composer.json src/Symfony/Component/Security/Http/Tests/Firewall/ExceptionListenerTest.php src/Symfony/Component/Security/Http/Tests/Firewall/RememberMeListenerTest.php
2 parents 11e6c48 + d4d686c commit 734bfd2

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

EventListener/RouterListener.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,8 +147,7 @@ public function onKernelRequest(GetResponseEvent $event)
147147
}
148148

149149
$request->attributes->add($parameters);
150-
unset($parameters['_route']);
151-
unset($parameters['_controller']);
150+
unset($parameters['_route'], $parameters['_controller']);
152151
$request->attributes->set('_route_params', $parameters);
153152
} catch (ResourceNotFoundException $e) {
154153
$message = sprintf('No route found for "%s %s"', $request->getMethod(), $request->getPathInfo());

Tests/DataCollector/LoggerDataCollectorTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public function testCollect($nb, $logs, $expectedLogs, $expectedDeprecationCount
2929

3030
$this->assertSame('logger', $c->getName());
3131
$this->assertSame($nb, $c->countErrors());
32-
$this->assertSame($expectedLogs ? $expectedLogs : $logs, $c->getLogs());
32+
$this->assertSame($expectedLogs ?: $logs, $c->getLogs());
3333
$this->assertSame($expectedDeprecationCount, $c->countDeprecations());
3434
$this->assertSame($expectedScreamCount, $c->countScreams());
3535

0 commit comments

Comments
 (0)