do not mock event classes

Author: xabbuh

Tests/EventListener/AddRequestFormatsListenerTest.php

@@ -16,6 +16,7 @@
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpKernel\Event\RequestEvent;
 use Symfony\Component\HttpKernel\EventListener\AddRequestFormatsListener;
+use Symfony\Component\HttpKernel\HttpKernelInterface;
 use Symfony\Component\HttpKernel\KernelEvents;
 
 /**
@@ -54,22 +55,12 @@ public function testRegisteredEvent()
     public function testSetAdditionalFormats()
     {
         $request = $this->createMock(Request::class);
-        $event = $this->getRequestEventMock($request);
+        $event = new RequestEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MASTER_REQUEST);
 
         $request->expects($this->once())
             ->method('setFormat')
             ->with('csv', ['text/csv', 'text/plain']);
 
         $this->listener->onKernelRequest($event);
     }
-
-    protected function getRequestEventMock(Request $request)
-    {
-        $event = $this->createMock(RequestEvent::class);
-        $event->expects($this->any())
-            ->method('getRequest')
-            ->willReturn($request);
-
-        return $event;
-    }
 }

Tests/EventListener/SaveSessionListenerTest.php

@@ -26,13 +26,17 @@ class SaveSessionListenerTest extends TestCase
 {
     public function testOnlyTriggeredOnMasterRequest()
     {
+        $session = $this->createMock(SessionInterface::class);
+        $session->expects($this->never())->method('save');
+        $session->expects($this->any())->method('isStarted')->willReturn(true);
+
+        $request = new Request();
+        $request->setSession($session);
+
         $listener = new SaveSessionListener();
-        $event = $this->createMock(ResponseEvent::class);
-        $event->expects($this->once())->method('isMasterRequest')->willReturn(false);
-        $event->expects($this->never())->method('getRequest');
 
         // sub request
-        $listener->onKernelResponse($event);
+        $listener->onKernelResponse(new ResponseEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::SUB_REQUEST, new Response()));
     }
 
     public function testSessionSaved()

Tests/EventListener/SessionListenerTest.php

@@ -58,9 +58,7 @@ public function testSessionIsSet()
         $request = new Request();
         $listener = new SessionListener($container);
 
-        $event = $this->createMock(RequestEvent::class);
-        $event->expects($this->exactly(2))->method('isMasterRequest')->willReturn(true);
-        $event->expects($this->once())->method('getRequest')->willReturn($request);
+        $event = new RequestEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MASTER_REQUEST);
 
         $listener->onKernelRequest($event);