Merge branch '5.4' into 6.0

* 5.4:
  [FrameworkBundle][HttpKernel] Add the ability to enable the profiler using a parameter
  [FrameworkBundle] Trigger deprecations on stderr instead of using trigger_deprecation call
  Add PhpStanExtractor
  [Messenger] allow processing messages in batches
  [Console] Fix backslash escaping in bash completion
  Add missing validators translation
  add suggestions for debug:firewall, debug:form, debug:messenger, debug:router
  [SecurityBundle] Deprecate not configuring explicitly a provider for custom_authenticators when there is more than one registered provider
  [Inflector] Fix inflector for "zombies"
  [Config] Add some cache on SelfCheckingResourceChecker
  fix AJAX request unit spacing
  fix ErrorExcception in CacheWarmerAggregate
  Prevent FormLoginAuthenticator from responding to requests that should be handled by JsonLoginAuthenticator
  Fix wait duration for fixed window policy
  Add exact command used to trigger invocation to the completion debug log
  [Translation] correctly handle intl domains with TargetOperation
  Allow using param as connection atribute in `*.event_subscriber` and `*.event_listener` tags

Author: derrabus

CHANGELOG.md

@@ -13,6 +13,7 @@ CHANGELOG
 5.4
 ---
 
+ * Add the ability to enable the profiler using a request query parameter, body parameter or attribute
  * Deprecate `AbstractTestSessionListener::getSession` inject a session in the request instead
  * Deprecate the `fileLinkFormat` parameter of `DebugHandlersListener`
  * Add support for configuring log level, and status code by exception class

CacheWarmer/CacheWarmerAggregate.php

@@ -104,7 +104,9 @@ public function warmUp(string $cacheDir): array
 
                 if (is_file($this->deprecationLogsFilepath)) {
                     $previousLogs = unserialize(file_get_contents($this->deprecationLogsFilepath));
-                    $collectedLogs = array_merge($previousLogs, $collectedLogs);
+                    if (\is_array($previousLogs)) {
+                        $collectedLogs = array_merge($previousLogs, $collectedLogs);
+                    }
                 }
 
                 file_put_contents($this->deprecationLogsFilepath, serialize(array_values($collectedLogs)));

EventListener/ProfilerListener.php

@@ -36,13 +36,14 @@ class ProfilerListener implements EventSubscriberInterface
     private ?\Throwable $exception = null;
     private \SplObjectStorage $profiles;
     private RequestStack $requestStack;
+    private ?string $collectParameter;
     private \SplObjectStorage $parents;
 
     /**
      * @param bool $onlyException    True if the profiler only collects data when an exception occurs, false otherwise
      * @param bool $onlyMainRequests True if the profiler only collects data when the request is the main request, false otherwise
      */
-    public function __construct(Profiler $profiler, RequestStack $requestStack, RequestMatcherInterface $matcher = null, bool $onlyException = false, bool $onlyMainRequests = false)
+    public function __construct(Profiler $profiler, RequestStack $requestStack, RequestMatcherInterface $matcher = null, bool $onlyException = false, bool $onlyMainRequests = false, string $collectParameter = null)
     {
         $this->profiler = $profiler;
         $this->matcher = $matcher;
@@ -51,6 +52,7 @@ public function __construct(Profiler $profiler, RequestStack $requestStack, Requ
         $this->profiles = new \SplObjectStorage();
         $this->parents = new \SplObjectStorage();
         $this->requestStack = $requestStack;
+        $this->collectParameter = $collectParameter;
     }
 
     /**
@@ -79,6 +81,10 @@ public function onKernelResponse(ResponseEvent $event)
         }
 
         $request = $event->getRequest();
+        if (null !== $this->collectParameter && null !== $collectParameterValue = $request->get($this->collectParameter)) {
+            true === $collectParameterValue || filter_var($collectParameterValue, \FILTER_VALIDATE_BOOLEAN) ? $this->profiler->enable() : $this->profiler->disable();
+        }
+
         $exception = $this->exception;
         $this->exception = null;
 

Tests/EventListener/ProfilerListenerTest.php

@@ -59,4 +59,42 @@ public function testKernelTerminate()
 
         $listener->onKernelTerminate(new TerminateEvent($kernel, $mainRequest, $response));
     }
+
+    /**
+     * @dataProvider collectRequestProvider
+     */
+    public function testCollectParameter(Request $request, ?bool $enable)
+    {
+        $profile = new Profile('token');
+
+        $profiler = $this->createMock(Profiler::class);
+        $profiler->expects($this->once())
+            ->method('collect')
+            ->willReturn($profile);
+
+        $profiler
+            ->expects(null === $enable ? $this->never() : $this->once())
+            ->method($enable ? 'enable' : 'disable');
+
+        $kernel = $this->createMock(HttpKernelInterface::class);
+        $response = new Response();
+
+        $requestStack = new RequestStack();
+        $requestStack->push($request);
+
+        $listener = new ProfilerListener($profiler, $requestStack, null, false, false, 'profile');
+
+        $listener->onKernelResponse(new ResponseEvent($kernel, $request, Kernel::MAIN_REQUEST, $response));
+    }
+
+    public function collectRequestProvider(): iterable
+    {
+        yield [Request::create('/'), null];
+        yield [Request::create('/', 'GET', ['profile' => '1']), true];
+        yield [Request::create('/', 'GET', ['profile' => '0']), false];
+
+        $request = Request::create('/');
+        $request->attributes->set('profile', true);
+        yield [$request, true];
+    }
 }