Merge branch '4.4' into 5.2

* 4.4:
  do not mock the Request class
  do not mock event classes
  recover from failed deserializations
  [ErrorHandle] Remove a link from the exception page
  [Validator] Added Ukrainian translations
  [GHA] Clarify some bits in the deps=high script

Author: xabbuh

HttpCache/Store.php

@@ -298,7 +298,7 @@ private function getMetadata(string $key): array
             return [];
         }
 
-        return unserialize($entries);
+        return unserialize($entries) ?: [];
     }
 
     /**

Tests/EventListener/AddRequestFormatsListenerTest.php

@@ -16,6 +16,7 @@
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpKernel\Event\RequestEvent;
 use Symfony\Component\HttpKernel\EventListener\AddRequestFormatsListener;
+use Symfony\Component\HttpKernel\HttpKernelInterface;
 use Symfony\Component\HttpKernel\KernelEvents;
 
 /**
@@ -54,22 +55,12 @@ public function testRegisteredEvent()
     public function testSetAdditionalFormats()
     {
         $request = $this->createMock(Request::class);
-        $event = $this->getRequestEventMock($request);
+        $event = new RequestEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MASTER_REQUEST);
 
         $request->expects($this->once())
             ->method('setFormat')
             ->with('csv', ['text/csv', 'text/plain']);
 
         $this->listener->onKernelRequest($event);
     }
-
-    protected function getRequestEventMock(Request $request)
-    {
-        $event = $this->createMock(RequestEvent::class);
-        $event->expects($this->any())
-            ->method('getRequest')
-            ->willReturn($request);
-
-        return $event;
-    }
 }

Tests/EventListener/DisallowRobotsIndexingListenerTest.php

@@ -29,7 +29,7 @@ public function testInvoke(?string $expected, array $responseArgs)
         $response = new Response(...$responseArgs);
         $listener = new DisallowRobotsIndexingListener();
 
-        $event = new ResponseEvent($this->createMock(HttpKernelInterface::class), $this->createMock(Request::class), KernelInterface::MASTER_REQUEST, $response);
+        $event = new ResponseEvent($this->createMock(HttpKernelInterface::class), new Request(), KernelInterface::MASTER_REQUEST, $response);
 
         $listener->onResponse($event);
 

Tests/EventListener/SessionListenerTest.php

@@ -61,9 +61,7 @@ public function testSessionIsSet()
         $request = new Request();
         $listener = new SessionListener($container);
 
-        $event = $this->createMock(RequestEvent::class);
-        $event->expects($this->exactly(2))->method('isMasterRequest')->willReturn(true);
-        $event->expects($this->once())->method('getRequest')->willReturn($request);
+        $event = new RequestEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MASTER_REQUEST);
 
         $listener->onKernelRequest($event);