Skip to content

Commit 342a362

Browse files
committed
Merge branch '5.4' into 6.0
* 5.4: [Translation] Translate translatable parameters Implement Message Stream for Postmark Mailer Sort services in service locator according to priority Relax service locator tests. Allow any order [Serializer] Add support for collecting type error during denormalization
2 parents ecedadc + c026f4b commit 342a362

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

Tests/DependencyInjection/RegisterControllerArgumentLocatorsPassTest.php

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,8 @@ public function testNoExceptionOnNonExistentTypeHintOptionalArg()
249249
$pass->process($container);
250250

251251
$locator = $container->getDefinition((string) $resolver->getArgument(0))->getArgument(0);
252-
$this->assertSame(['foo::barAction', 'foo::fooAction'], array_keys($locator));
252+
253+
$this->assertEqualsCanonicalizing(['foo::barAction', 'foo::fooAction'], array_keys($locator));
253254
}
254255

255256
public function testArgumentWithNoTypeHintIsOk()
@@ -396,7 +397,10 @@ public function testAlias()
396397
$pass->process($container);
397398

398399
$locator = $container->getDefinition((string) $resolver->getArgument(0))->getArgument(0);
399-
$this->assertSame([RegisterTestController::class.'::fooAction', 'foo::fooAction'], array_keys($locator));
400+
401+
$services = array_keys($locator);
402+
sort($services);
403+
$this->assertSame([RegisterTestController::class.'::fooAction', 'foo::fooAction'], $services);
400404
}
401405

402406
public function testBindWithTarget()

Tests/DependencyInjection/RemoveEmptyControllerArgumentLocatorsPassTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public function testProcess()
5757
'Symfony\Component\HttpKernel\DependencyInjection\RemoveEmptyControllerArgumentLocatorsPass: Removing method "setTestCase" of service "c2" from controller candidates: the method is called at instantiation, thus cannot be an action.',
5858
];
5959

60-
$this->assertSame($expectedLog, $container->getCompiler()->getLog());
60+
$this->assertEqualsCanonicalizing($expectedLog, $container->getCompiler()->getLog());
6161
}
6262

6363
public function testInvoke()

0 commit comments

Comments
 (0)