You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
minor #47472 Removed unused $event param of onKernelFinishRequest from RouterListener (githubfromgui)
This PR was merged into the 6.2 branch.
Discussion
----------
Removed unused $event param of onKernelFinishRequest from RouterListener
| Q | A
| ------------- | ---
| Branch? | 6.2
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| License | MIT
The `$event` parameter in the `onKernelFinishRequest` for the `RouterListener` class seems to not be used. Other listeners such as `LocaleAwareListener`, `Firewall` and `FirewallListener` all takes advantage of this $event parameter.
`Symfony\Component\HttpKernel\EventListener\LocaleAwareListener`:

`Symfony\Component\Security\Http\Firewall`:

`Symfony\Bundle\SecurityBundle\EventListener\FirewallListener`:

Plus, I could not find any Interface that ensures any contract over this method to all these classes above.
Commits
-------
3ff970677d Removed unused the $event parameter of onKernelFinishRequest from RouterListener.
0 commit comments