use value of DIRECTORY_SEPARATOR to detect Windows

xabbuh · xabbuh · commit 1bc2fec1d1e8 · 2014-12-30T12:17:23.000+01:00
This commit unifies the detection of Windows builds across the Symfony
codebase.
diff --git a/Tests/KernelTest.php b/Tests/KernelTest.php
@@ -341,7 +341,7 @@ public function doStuff()
 
         // Heredocs are preserved, making the output mixing Unix and Windows line
         // endings, switching to "\n" everywhere on Windows to avoid failure.
-        if (defined('PHP_WINDOWS_VERSION_MAJOR')) {
+        if ('\\' === DIRECTORY_SEPARATOR) {
             $expected = str_replace("\r\n", "\n", $expected);
             $output = str_replace("\r\n", "\n", $output);
         }

Original file line number	Diff line number	Diff line change
`@@ -341,7 +341,7 @@ public function doStuff()`
`341`	`341`
`342`	`342`	`// Heredocs are preserved, making the output mixing Unix and Windows line`
`343`	`343`	`// endings, switching to "\n" everywhere on Windows to avoid failure.`
`344`		`- if (defined('PHP_WINDOWS_VERSION_MAJOR')) {`
	`344`	`+ if ('\\' === DIRECTORY_SEPARATOR) {`
`345`	`345`	`$expected = str_replace("\r\n", "\n", $expected);`
`346`	`346`	`$output = str_replace("\r\n", "\n", $output);`
`347`	`347`	`}`