Use ::class keyword when possible

Author: fabpot

Request.php

@@ -1941,7 +1941,7 @@ private function setPhpDefaultLocale(string $locale): void
         // setting the default locale, the intl module is not installed, and
         // the call can be ignored:
         try {
-            if (class_exists('Locale', false)) {
+            if (class_exists(\Locale::class, false)) {
                 \Locale::setDefault($locale);
             }
         } catch (\Exception $e) {

Tests/BinaryFileResponseTest.php

@@ -48,7 +48,7 @@ public function testConstructWithNonAsciiFilename()
 
     public function testSetContent()
     {
-        $this->expectException('LogicException');
+        $this->expectException(\LogicException::class);
         $response = new BinaryFileResponse(__FILE__);
         $response->setContent('foo');
     }

Tests/CookieTest.php

@@ -43,7 +43,7 @@ public function namesWithSpecialCharacters()
      */
     public function testInstantiationThrowsExceptionIfRawCookieNameContainsSpecialCharacters($name)
     {
-        $this->expectException('InvalidArgumentException');
+        $this->expectException(\InvalidArgumentException::class);
         Cookie::create($name, null, 0, null, null, null, false, true);
     }
 
@@ -57,13 +57,13 @@ public function testInstantiationSucceedNonRawCookieNameContainsSpecialCharacter
 
     public function testInstantiationThrowsExceptionIfCookieNameIsEmpty()
     {
-        $this->expectException('InvalidArgumentException');
+        $this->expectException(\InvalidArgumentException::class);
         Cookie::create('');
     }
 
     public function testInvalidExpiration()
     {
-        $this->expectException('InvalidArgumentException');
+        $this->expectException(\InvalidArgumentException::class);
         Cookie::create('MyCookie', 'foo', 'bar');
     }
 

Tests/ExpressionRequestMatcherTest.php

@@ -20,7 +20,7 @@ class ExpressionRequestMatcherTest extends TestCase
 {
     public function testWhenNoExpressionIsSet()
     {
-        $this->expectException('LogicException');
+        $this->expectException(\LogicException::class);
         $expressionRequestMatcher = new ExpressionRequestMatcher();
         $expressionRequestMatcher->matches(new Request());
     }

Tests/File/FileTest.php

@@ -41,7 +41,7 @@ public function testGuessExtensionIsBasedOnMimeType()
 
     public function testConstructWhenFileNotExists()
     {
-        $this->expectException('Symfony\Component\HttpFoundation\File\Exception\FileNotFoundException');
+        $this->expectException(\Symfony\Component\HttpFoundation\File\Exception\FileNotFoundException::class);
 
         new File(__DIR__.'/Fixtures/not_here');
     }
@@ -57,7 +57,7 @@ public function testMove()
 
         $file = new File($path);
         $movedFile = $file->move($targetDir);
-        $this->assertInstanceOf('Symfony\Component\HttpFoundation\File\File', $movedFile);
+        $this->assertInstanceOf(File::class, $movedFile);
 
         $this->assertFileExists($targetPath);
         $this->assertFileDoesNotExist($path);
@@ -111,7 +111,7 @@ public function testMoveWithNonLatinName($filename, $sanitizedFilename)
 
         $file = new File($path);
         $movedFile = $file->move($targetDir, $filename);
-        $this->assertInstanceOf('Symfony\Component\HttpFoundation\File\File', $movedFile);
+        $this->assertInstanceOf(File::class, $movedFile);
 
         $this->assertFileExists($targetPath);
         $this->assertFileDoesNotExist($path);

Tests/File/MimeType/MimeTypeTest.php

@@ -39,7 +39,7 @@ public function testGuessImageWithoutExtension()
 
     public function testGuessImageWithDirectory()
     {
-        $this->expectException('Symfony\Component\HttpFoundation\File\Exception\FileNotFoundException');
+        $this->expectException(\Symfony\Component\HttpFoundation\File\Exception\FileNotFoundException::class);
 
         MimeTypeGuesser::getInstance()->guess(__DIR__.'/../Fixtures/directory');
     }
@@ -68,7 +68,7 @@ public function testGuessWithDuplicatedFileType()
 
     public function testGuessWithIncorrectPath()
     {
-        $this->expectException('Symfony\Component\HttpFoundation\File\Exception\FileNotFoundException');
+        $this->expectException(\Symfony\Component\HttpFoundation\File\Exception\FileNotFoundException::class);
         MimeTypeGuesser::getInstance()->guess(__DIR__.'/../Fixtures/not_here');
     }
 
@@ -87,7 +87,7 @@ public function testGuessWithNonReadablePath()
         @chmod($path, 0333);
 
         if ('0333' == substr(sprintf('%o', fileperms($path)), -4)) {
-            $this->expectException('Symfony\Component\HttpFoundation\File\Exception\AccessDeniedException');
+            $this->expectException(\Symfony\Component\HttpFoundation\File\Exception\AccessDeniedException::class);
             MimeTypeGuesser::getInstance()->guess($path);
         } else {
             $this->markTestSkipped('Can not verify chmod operations, change of file permissions failed');

Tests/File/UploadedFileTest.php

@@ -33,7 +33,7 @@ protected function setUp(): void
 
     public function testConstructWhenFileNotExists()
     {
-        $this->expectException('Symfony\Component\HttpFoundation\File\Exception\FileNotFoundException');
+        $this->expectException(\Symfony\Component\HttpFoundation\File\Exception\FileNotFoundException::class);
 
         new UploadedFile(
             __DIR__.'/Fixtures/not_here',
@@ -144,7 +144,7 @@ public function testGetClientOriginalExtension()
 
     public function testMoveLocalFileIsNotAllowed()
     {
-        $this->expectException('Symfony\Component\HttpFoundation\File\Exception\FileException');
+        $this->expectException(FileException::class);
         $file = new UploadedFile(
             __DIR__.'/Fixtures/test.gif',
             'original.gif',

Tests/FileBagTest.php

@@ -25,7 +25,7 @@ class FileBagTest extends TestCase
 {
     public function testFileMustBeAnArrayOrUploadedFile()
     {
-        $this->expectException('InvalidArgumentException');
+        $this->expectException(\InvalidArgumentException::class);
         new FileBag(['file' => 'foo']);
     }
 

Tests/HeaderBagTest.php

@@ -45,7 +45,7 @@ public function testGetDate()
     {
         $bag = new HeaderBag(['foo' => 'Tue, 4 Sep 2012 20:00:00 +0200']);
         $headerDate = $bag->getDate('foo');
-        $this->assertInstanceOf('DateTime', $headerDate);
+        $this->assertInstanceOf(\DateTime::class, $headerDate);
     }
 
     public function testGetDateNull()
@@ -57,7 +57,7 @@ public function testGetDateNull()
 
     public function testGetDateException()
     {
-        $this->expectException('RuntimeException');
+        $this->expectException(\RuntimeException::class);
         $bag = new HeaderBag(['foo' => 'Tue']);
         $bag->getDate('foo');
     }

Tests/HeaderUtilsTest.php

@@ -99,7 +99,7 @@ public function testUnquote()
 
     public function testMakeDispositionInvalidDisposition()
     {
-        $this->expectException('InvalidArgumentException');
+        $this->expectException(\InvalidArgumentException::class);
         HeaderUtils::makeDisposition('invalid', 'foo.html');
     }
 
@@ -128,7 +128,7 @@ public function provideMakeDisposition()
      */
     public function testMakeDispositionFail($disposition, $filename)
     {
-        $this->expectException('InvalidArgumentException');
+        $this->expectException(\InvalidArgumentException::class);
         HeaderUtils::makeDisposition($disposition, $filename);
     }