Fix MockArraySessionStorage to generate more conform ids

Seldaek · web-flow · commit a33dd713e17a · 2024-06-28T17:37:05.000+02:00
diff --git a/Session/Storage/MockArraySessionStorage.php b/Session/Storage/MockArraySessionStorage.php
@@ -226,14 +226,11 @@ public function getMetadataBag()
     /**
      * Generates a session ID.
      *
-     * This doesn't need to be particularly cryptographically secure since this is just
-     * a mock.
-     *
      * @return string
      */
     protected function generateId()
     {
-        return hash('sha256', uniqid('ss_mock_', true));
+        return bin2hex(random_bytes(16));
     }
 
     protected function loadSession()

Original file line number	Diff line number	Diff line change
`@@ -226,14 +226,11 @@ public function getMetadataBag()`
`226`	`226`	`/**`
`227`	`227`	`* Generates a session ID.`
`228`	`228`	`*`
`229`		`- * This doesn't need to be particularly cryptographically secure since this is just`
`230`		`- * a mock.`
`231`		`- *`
`232`	`229`	`* @return string`
`233`	`230`	`*/`
`234`	`231`	`protected function generateId()`
`235`	`232`	`{`
`236`		`- return hash('sha256', uniqid('ss_mock_', true));`
	`233`	`+ return bin2hex(random_bytes(16));`
`237`	`234`	`}`
`238`	`235`
`239`	`236`	`protected function loadSession()`