Move array_merge calls out of loops to improve performance

simonberger · simonberger · commit 2561c6bf1835 · 2021-10-04T20:34:22.000+02:00
diff --git a/Response.php b/Response.php
@@ -1048,10 +1048,10 @@ public function getVary(): array
 
         $ret = [];
         foreach ($vary as $item) {
-            $ret = array_merge($ret, preg_split('/[\s,]+/', $item));
+            $ret[] = preg_split('/[\s,]+/', $item);
         }
 
-        return $ret;
+        return array_merge([], ...$ret);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -1048,10 +1048,10 @@ public function getVary(): array`
`1048`	`1048`
`1049`	`1049`	`$ret = [];`
`1050`	`1050`	`foreach ($vary as $item) {`
`1051`		`- $ret = array_merge($ret, preg_split('/[\s,]+/', $item));`
	`1051`	`+ $ret[] = preg_split('/[\s,]+/', $item);`
`1052`	`1052`	`}`
`1053`	`1053`
`1054`		`- return $ret;`
	`1054`	`+ return array_merge([], ...$ret);`
`1055`	`1055`	`}`
`1056`	`1056`
`1057`	`1057`	`/**`