Add void return types

Author: wouterj

AmpHttpClient.php

@@ -153,7 +153,7 @@ public function stream(ResponseInterface|iterable $responses, float $timeout = n
         return new ResponseStream(AmpResponse::stream($responses, $timeout));
     }
 
-    public function reset()
+    public function reset(): void
     {
         $this->multi->dnsCache = [];
 

CachingHttpClient.php

@@ -135,6 +135,9 @@ public function stream(ResponseInterface|iterable $responses, float $timeout = n
         })());
     }
 
+    /**
+     * @return void
+     */
     public function reset()
     {
         if ($this->client instanceof ResetInterface) {

CurlHttpClient.php

@@ -324,7 +324,7 @@ public function stream(ResponseInterface|iterable $responses, float $timeout = n
         return new ResponseStream(CurlResponse::stream($responses, $timeout));
     }
 
-    public function reset()
+    public function reset(): void
     {
         $this->multi->reset();
     }

DataCollector/HttpClientDataCollector.php

@@ -31,17 +31,17 @@ final class HttpClientDataCollector extends DataCollector implements LateDataCol
      */
     private array $clients = [];
 
-    public function registerClient(string $name, TraceableHttpClient $client)
+    public function registerClient(string $name, TraceableHttpClient $client): void
     {
         $this->clients[$name] = $client;
     }
 
-    public function collect(Request $request, Response $response, \Throwable $exception = null)
+    public function collect(Request $request, Response $response, \Throwable $exception = null): void
     {
         $this->lateCollect();
     }
 
-    public function lateCollect()
+    public function lateCollect(): void
     {
         $this->data['request_count'] = $this->data['request_count'] ?? 0;
         $this->data['error_count'] = $this->data['error_count'] ?? 0;
@@ -86,7 +86,7 @@ public function getName(): string
         return 'http_client';
     }
 
-    public function reset()
+    public function reset(): void
     {
         $this->data = [
             'clients' => [],

DecoratorTrait.php

@@ -48,6 +48,9 @@ public function withOptions(array $options): static
         return $clone;
     }
 
+    /**
+     * @return void
+     */
     public function reset()
     {
         if ($this->client instanceof ResetInterface) {

DependencyInjection/HttpClientPass.php

@@ -19,7 +19,7 @@
 
 final class HttpClientPass implements CompilerPassInterface
 {
-    public function process(ContainerBuilder $container)
+    public function process(ContainerBuilder $container): void
     {
         if (!$container->hasDefinition('data_collector.http_client')) {
             return;

HttplugClient.php

@@ -266,7 +266,7 @@ public function __destruct()
         $this->wait();
     }
 
-    public function reset()
+    public function reset(): void
     {
         if ($this->client instanceof ResetInterface) {
             $this->client->reset();

Internal/Canary.php

@@ -25,7 +25,7 @@ public function __construct(\Closure $canceller)
         $this->canceller = $canceller;
     }
 
-    public function cancel()
+    public function cancel(): void
     {
         if (isset($this->canceller)) {
             $canceller = $this->canceller;

Internal/CurlClientState.php

@@ -77,7 +77,7 @@ public function __construct(int $maxHostConnections, int $maxPendingPushes)
         curl_multi_setopt($this->handle, \CURLMOPT_PUSHFUNCTION, static fn ($parent, $pushed, array $requestHeaders) => $multi->handlePush($parent, $pushed, $requestHeaders, $maxPendingPushes));
     }
 
-    public function reset()
+    public function reset(): void
     {
         foreach ($this->pushedResponses as $url => $response) {
             $this->logger?->debug(sprintf('Unused pushed response: "%s"', $url));

Internal/NativeClientState.php

@@ -34,7 +34,7 @@ public function __construct()
         $this->id = random_int(\PHP_INT_MIN, \PHP_INT_MAX);
     }
 
-    public function reset()
+    public function reset(): void
     {
         $this->responseCount = 0;
         $this->dnsCache = [];