Skip to content

Commit 810397d

Browse files
Merge branch '5.4' into 6.0
* 5.4: fix merge [HttpClient] mark test transient [Mime] Fix test [Translation] Fix TranslationPullCommand with ICU translations [PropertyInfo] Fix phpstan extractor issues Allow package-versions-deprecated plugin Update security.lb.xlf [Notifier] Use correct factory for the msteams transport Fix SessionListener without session in request Remove direct dependency on composer/package-versions-deprecated Remove the unused dependency on composer/package-versions-deprecated [Security/Http] Fix cookie clearing on logout [HttpClient] fix checking for recent curl consts
2 parents fcdb5a4 + 0ea5f17 commit 810397d

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

CurlHttpClient.php

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -432,8 +432,6 @@ private function validateExtraCurlOptions(array $options): void
432432
\CURLOPT_INFILESIZE => 'body',
433433
\CURLOPT_POSTFIELDS => 'body',
434434
\CURLOPT_UPLOAD => 'body',
435-
\CURLOPT_PINNEDPUBLICKEY => 'peer_fingerprint',
436-
\CURLOPT_UNIX_SOCKET_PATH => 'bindto',
437435
\CURLOPT_INTERFACE => 'bindto',
438436
\CURLOPT_TIMEOUT_MS => 'max_duration',
439437
\CURLOPT_TIMEOUT => 'max_duration',
@@ -456,6 +454,14 @@ private function validateExtraCurlOptions(array $options): void
456454
\CURLOPT_PROGRESSFUNCTION => 'on_progress',
457455
];
458456

457+
if (\defined('CURLOPT_UNIX_SOCKET_PATH')) {
458+
$curloptsToConfig[\CURLOPT_UNIX_SOCKET_PATH] = 'bindto';
459+
}
460+
461+
if (\defined('CURLOPT_PINNEDPUBLICKEY')) {
462+
$curloptsToConfig[\CURLOPT_PINNEDPUBLICKEY] = 'peer_fingerprint';
463+
}
464+
459465
$curloptsToCheck = [
460466
\CURLOPT_PRIVATE,
461467
\CURLOPT_HEADERFUNCTION,

Tests/HttpClientTestCase.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,9 @@ abstract class HttpClientTestCase extends BaseHttpClientTestCase
3232
{
3333
private static $vulcainStarted = false;
3434

35+
/**
36+
* @group transient-on-macos
37+
*/
3538
public function testTimeoutOnDestruct()
3639
{
3740
if (!method_exists(parent::class, 'testTimeoutOnDestruct')) {

0 commit comments

Comments
 (0)