bug #44428 [HttpClient] Fix response id property check in MockResponse (fancyweb)

This PR was merged into the 6.0 branch.

Discussion
----------

[HttpClient] Fix response id property check in MockResponse

| Q             | A
| ------------- | ---
| Branch?       | 6.0
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Since we typed the `$id` property, the check must be changed to not trigger the "accessed before initialization" error.

Commits
-------

cb4706410c [HttpClient] Fix response id property check in MockResponse

Author: nicolas-grekas

Response/MockResponse.php

@@ -159,7 +159,7 @@ public static function fromRequest(string $method, string $url, array $options,
      */
     protected static function schedule(self $response, array &$runningResponses): void
     {
-        if (!$response->id) {
+        if (!isset($response->id)) {
             throw new InvalidArgumentException('MockResponse instances must be issued by MockHttpClient before processing.');
         }
 

Tests/Response/MockResponseTest.php

@@ -3,6 +3,7 @@
 namespace Symfony\Component\HttpClient\Tests\Response;
 
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\HttpClient\Exception\InvalidArgumentException;
 use Symfony\Component\HttpClient\Exception\JsonException;
 use Symfony\Component\HttpClient\Exception\TransportException;
 use Symfony\Component\HttpClient\Response\MockResponse;
@@ -107,4 +108,12 @@ public function testErrorIsTakenIntoAccountInInitialization()
             'error' => 'ccc error',
         ]))->getStatusCode();
     }
+
+    public function testMustBeIssuedByMockHttpClient()
+    {
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('MockResponse instances must be issued by MockHttpClient before processing.');
+
+        (new MockResponse())->getContent();
+    }
 }