Skip to content

Commit f5e4847

Browse files
committed
Merge branch '3.4' into 4.4
* 3.4: Add missing dots at the end of exception messages
2 parents c021361 + 7224570 commit f5e4847

File tree

7 files changed

+8
-8
lines changed

7 files changed

+8
-8
lines changed

Command/AbstractConfigCommand.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,11 +112,11 @@ protected function findExtension($name)
112112
public function validateConfiguration(ExtensionInterface $extension, $configuration)
113113
{
114114
if (!$configuration) {
115-
throw new \LogicException(sprintf('The extension with alias "%s" does not have its getConfiguration() method setup', $extension->getAlias()));
115+
throw new \LogicException(sprintf('The extension with alias "%s" does not have its getConfiguration() method setup.', $extension->getAlias()));
116116
}
117117

118118
if (!$configuration instanceof ConfigurationInterface) {
119-
throw new \LogicException(sprintf('Configuration class "%s" should implement ConfigurationInterface in order to be dumpable', \get_class($configuration)));
119+
throw new \LogicException(sprintf('Configuration class "%s" should implement ConfigurationInterface in order to be dumpable.', \get_class($configuration)));
120120
}
121121
}
122122

Command/CacheClearCommand.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
8585
$fs->remove($oldCacheDir);
8686

8787
if (!is_writable($realCacheDir)) {
88-
throw new RuntimeException(sprintf('Unable to write in the "%s" directory', $realCacheDir));
88+
throw new RuntimeException(sprintf('Unable to write in the "%s" directory.', $realCacheDir));
8989
}
9090

9191
$io->comment(sprintf('Clearing the cache for the <info>%s</info> environment with debug <info>%s</info>', $kernel->getEnvironment(), var_export($kernel->isDebug(), true)));

Command/ConfigDebugCommand.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ private function getConfigForPath(array $config, string $path, string $alias)
145145

146146
foreach ($steps as $step) {
147147
if (!\array_key_exists($step, $config)) {
148-
throw new LogicException(sprintf('Unable to find configuration for "%s.%s"', $alias, $path));
148+
throw new LogicException(sprintf('Unable to find configuration for "%s.%s".', $alias, $path));
149149
}
150150

151151
$config = $config[$step];

DependencyInjection/Compiler/ProfilerPass.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public function process(ContainerBuilder $container)
3939

4040
if (isset($attributes[0]['template'])) {
4141
if (!isset($attributes[0]['id'])) {
42-
throw new InvalidArgumentException(sprintf('Data collector service "%s" must have an id attribute in order to specify a template', $id));
42+
throw new InvalidArgumentException(sprintf('Data collector service "%s" must have an id attribute in order to specify a template.', $id));
4343
}
4444
$template = [$attributes[0]['id'], $attributes[0]['template']];
4545
}

DependencyInjection/FrameworkExtension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1196,7 +1196,7 @@ private function registerTranslatorConfiguration(array $config, ContainerBuilder
11961196
if ($container->fileExists($dir)) {
11971197
$dirs[] = $transPaths[] = $dir;
11981198
} else {
1199-
throw new \UnexpectedValueException(sprintf('%s defined in translator.paths does not exist or is not a directory', $dir));
1199+
throw new \UnexpectedValueException(sprintf('%s defined in translator.paths does not exist or is not a directory.', $dir));
12001200
}
12011201
}
12021202

Templating/Helper/StopwatchHelper.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,6 @@ public function __call($method, $arguments = [])
4747
return $this->stopwatch->{$method}(...$arguments);
4848
}
4949

50-
throw new \BadMethodCallException(sprintf('Method "%s" of Stopwatch does not exist', $method));
50+
throw new \BadMethodCallException(sprintf('Method "%s" of Stopwatch does not exist.', $method));
5151
}
5252
}

Test/WebTestCase.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ protected static function createClient(array $options = [], array $server = [])
5353
if (class_exists(KernelBrowser::class)) {
5454
throw new \LogicException('You cannot create the client used in functional tests if the "framework.test" config is not set to true.');
5555
}
56-
throw new \LogicException('You cannot create the client used in functional tests if the BrowserKit component is not available. Try running "composer require symfony/browser-kit"');
56+
throw new \LogicException('You cannot create the client used in functional tests if the BrowserKit component is not available. Try running "composer require symfony/browser-kit".');
5757
}
5858

5959
$client->setServerParameters($server);

0 commit comments

Comments
 (0)