Skip to content

Commit f08a1c9

Browse files
author
Robin Chalas
committed
[FrameworkBundle] Don't register MessengerDataCollector if messenger is not enabled
1 parent 12938b2 commit f08a1c9

File tree

3 files changed

+20
-5
lines changed

3 files changed

+20
-5
lines changed

DependencyInjection/FrameworkExtension.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,7 @@ class FrameworkExtension extends Extension
108108
private $sessionConfigEnabled = false;
109109
private $annotationsConfigEnabled = false;
110110
private $validatorConfigEnabled = false;
111+
private $messengerConfigEnabled = false;
111112

112113
/**
113114
* Responds to the app.config configuration parameter.
@@ -269,7 +270,7 @@ public function load(array $configs, ContainerBuilder $container)
269270
$this->registerLockConfiguration($config['lock'], $container, $loader);
270271
}
271272

272-
if ($this->isConfigEnabled($container, $config['messenger'])) {
273+
if ($this->messengerConfigEnabled = $this->isConfigEnabled($container, $config['messenger'])) {
273274
$this->registerMessengerConfiguration($config['messenger'], $container, $loader, $config['serializer'], $config['validation']);
274275
} else {
275276
$container->removeDefinition('console.command.messenger_consume_messages');
@@ -445,6 +446,10 @@ private function registerProfilerConfiguration(array $config, ContainerBuilder $
445446
$container->getDefinition('translator.data_collector')->setDecoratedService('translator');
446447
}
447448

449+
if ($this->messengerConfigEnabled) {
450+
$loader->load('messenger_debug.xml');
451+
}
452+
448453
$container->setParameter('profiler_listener.only_exceptions', $config['only_exceptions']);
449454
$container->setParameter('profiler_listener.only_master_requests', $config['only_master_requests']);
450455

Resources/config/collectors.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,5 @@
5252
<tag name="kernel.event_listener" event="kernel.controller" method="onKernelController"/>
5353
<tag name="data_collector" template="@WebProfiler/Collector/router.html.twig" id="router" priority="285" />
5454
</service>
55-
56-
<service id="data_collector.messenger" class="Symfony\Component\Messenger\DataCollector\MessengerDataCollector">
57-
<tag name="data_collector" template="@WebProfiler/Collector/messenger.html.twig" id="messenger" priority="100" />
58-
</service>
5955
</services>
6056
</container>

Resources/config/messenger_debug.xml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
<?xml version="1.0" ?>
2+
3+
<container xmlns="http://symfony.com/schema/dic/services"
4+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
5+
xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd">
6+
7+
<services>
8+
<defaults public="false" />
9+
10+
<service id="data_collector.messenger" class="Symfony\Component\Messenger\DataCollector\MessengerDataCollector">
11+
<tag name="data_collector" template="@WebProfiler/Collector/messenger.html.twig" id="messenger" priority="100" />
12+
</service>
13+
</services>
14+
</container>

0 commit comments

Comments
 (0)