Skip to content

Commit d6d905b

Browse files
committed
Merge branch '4.3' into 4.4
* 4.3: Avoid stale-if-error if kernel.debug = true, because it hides errors [Console] Fix SymfonyQuestionHelper tests sometimes failing on AppVeyor [Workflow] Fix configuration node reference for "initial_marking" expand listener in place [DI] deferred exceptions in ResolveParameterPlaceHoldersPass
2 parents da9b32f + 1f9b46b commit d6d905b

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

HttpCache/HttpCache.php

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,14 @@ public function __construct(KernelInterface $kernel, string $cacheDir = null)
3636
$this->kernel = $kernel;
3737
$this->cacheDir = $cacheDir;
3838

39-
parent::__construct($kernel, $this->createStore(), $this->createSurrogate(), array_merge(['debug' => $kernel->isDebug()], $this->getOptions()));
39+
$isDebug = $kernel->isDebug();
40+
$options = ['debug' => $isDebug];
41+
42+
if ($isDebug) {
43+
$options['stale_if_error'] = 0;
44+
}
45+
46+
parent::__construct($kernel, $this->createStore(), $this->createSurrogate(), array_merge($options, $this->getOptions()));
4047
}
4148

4249
/**

0 commit comments

Comments
 (0)