Skip to content

Commit d45ffbc

Browse files
committed
minor #17480 Static code analysis (Koc)
This PR was merged into the 2.3 branch. Discussion ---------- Static code analysis | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Things that done: * fix case in method calls * removed unused imports * use shorter concat where it possible * optimize some css * removed duplicated array keys * removed redurant return statements * removed one-time variables * do not pass arguments that not used in functions Commits ------- 8db691a Static code analysis
2 parents 53566ba + c349a4d commit d45ffbc

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

Command/TranslationUpdateCommand.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
9595
$extractor = $this->getContainer()->get('translation.extractor');
9696
$extractor->setPrefix($input->getOption('prefix'));
9797
foreach ($bundleTransPaths as $path) {
98-
$path = $path.'views';
98+
$path .= 'views';
9999
if (is_dir($path)) {
100100
$extractor->extract($path, $extractedCatalogue);
101101
}
@@ -106,7 +106,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
106106
$output->writeln('Loading translation files');
107107
$loader = $this->getContainer()->get('translation.loader');
108108
foreach ($bundleTransPaths as $path) {
109-
$path = $path.'translations';
109+
$path .= 'translations';
110110
if (is_dir($path)) {
111111
$loader->loadMessages($path, $currentCatalogue);
112112
}
@@ -151,7 +151,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
151151
$output->writeln('Writing files');
152152
$bundleTransPath = false;
153153
foreach ($bundleTransPaths as $path) {
154-
$path = $path.'translations';
154+
$path .= 'translations';
155155
if (is_dir($path)) {
156156
$bundleTransPath = $path;
157157
}

Resources/public/css/body.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ build: 56
117117
background: transparent url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAcAAAAcCAYAAACtQ6WLAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAR1JREFUeNpiPHnyZCMDA8MNID5gZmb2nAEJMH7//v3N169fX969e/cYkL8WqGAHXPLv37//QYzfv39/fvPmzbUnT56sAXInmJub/2H5/x8sx8DCwsIrISFhDmQyPX78+CmQXs70798/BmQsKipqBNTgdvz4cWkmkE5kDATMioqKZkCFdiwg1eiAi4tLGqhQF24nMmBmZuYEigth1QkEbEBxTlySYPvJkwSJ00AnjYylgU6gxB8g/oFVEphkvgLF32KNMmCCewYUv4qhEyj47+HDhyeBzIMYOoEp8CxQw56wsLAncJ1//vz5/P79+2svX74EJc2V4BT58+fPd8CE/QKYHMGJOiIiAp6oWW7evDkNSF8DZYfIyEiU7AAQYACJ2vxVdJW4eQAAAABJRU5ErkJggg==) right top no-repeat;
118118
}
119119
.sf-button .btn-bg {
120-
padding: 0px 14px;
120+
padding: 0 14px;
121121
color: #636363;
122122
line-height: 28px;
123123
background: transparent url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAAcCAYAAACgXdXMAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAClJREFUeNpiPnny5EKGf//+/Wf6//8/A4QAcrGzKCZwGc9sa2urBBBgAIbDUoYVp9lmAAAAAElFTkSuQmCC) repeat-x top left;

0 commit comments

Comments
 (0)