Skip to content

Commit b340c3c

Browse files
Merge branch '2.3' into 2.7
* 2.3: [Process] Fix potential race condition typo [FrameworkBundle] Set the kernel.name properly after a cache warmup Removed spaces before semicolon
2 parents 4def6bf + 51a58ee commit b340c3c

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

Command/CacheClearCommand.php

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -158,9 +158,18 @@ protected function warmup($warmupDir, $realCacheDir, $enableOptionalWarmers = tr
158158
}
159159

160160
// fix references to kernel/container related classes
161-
$search = $tempKernel->getName().ucfirst($tempKernel->getEnvironment());
162-
$replace = $realKernel->getName().ucfirst($realKernel->getEnvironment());
163-
foreach (Finder::create()->files()->name($search.'*')->in($warmupDir) as $file) {
161+
$fileSearch = $tempKernel->getName().ucfirst($tempKernel->getEnvironment()).'*';
162+
$search = array(
163+
$tempKernel->getName().ucfirst($tempKernel->getEnvironment()),
164+
sprintf('\'kernel.name\' => \'%s\'', $tempKernel->getName()),
165+
sprintf('key="kernel.name">%s<', $tempKernel->getName()),
166+
);
167+
$replace = array(
168+
$realKernel->getName().ucfirst($realKernel->getEnvironment()),
169+
sprintf('\'kernel.name\' => \'%s\'', $realKernel->getName()),
170+
sprintf('key="kernel.name">%s<', $realKernel->getName()),
171+
);
172+
foreach (Finder::create()->files()->name($fileSearch)->in($warmupDir) as $file) {
164173
$content = str_replace($search, $replace, file_get_contents($file));
165174
file_put_contents(str_replace($search, $replace, $file), $content);
166175
unlink($file);

Tests/Command/CacheClearCommand/CacheClearCommandTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,5 +83,6 @@ public function testCacheIsFreshAfterCacheClearedWithWarmup()
8383
}
8484
}
8585
$this->assertTrue($found, 'Kernel file should present as resource');
86+
$this->assertRegExp(sprintf('/\'kernel.name\'\s*=>\s*\'%s\'/', $this->kernel->getName()), file_get_contents($containerFile), 'kernel.name is properly set on the dumped container');
8687
}
8788
}

0 commit comments

Comments
 (0)