Deprecate configuring tag names and service ids in compiler passes

nicolas-grekas · nicolas-grekas · commit a680961fd085 · 2021-03-15T19:33:21.000+01:00
diff --git a/DependencyInjection/Compiler/TestServiceContainerWeakRefPass.php b/DependencyInjection/Compiler/TestServiceContainerWeakRefPass.php
@@ -26,6 +26,10 @@ class TestServiceContainerWeakRefPass implements CompilerPassInterface
 
     public function __construct(string $privateTagName = 'container.private')
     {
+        if (0 < \func_num_args()) {
+            trigger_deprecation('symfony/framework-bundle', '5.3', 'Configuring "%s" is deprecated.', __CLASS__);
+        }
+
         $this->privateTagName = $privateTagName;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,10 @@ class TestServiceContainerWeakRefPass implements CompilerPassInterface`
`26`	`26`
`27`	`27`	`public function __construct(string $privateTagName = 'container.private')`
`28`	`28`	`{`
	`29`	`+ if (0 < \func_num_args()) {`
	`30`	`+ trigger_deprecation('symfony/framework-bundle', '5.3', 'Configuring "%s" is deprecated.', __CLASS__);`
	`31`	`+ }`
	`32`	`+`
`29`	`33`	`$this->privateTagName = $privateTagName;`
`30`	`34`	`}`
`31`	`35`