Skip to content

Commit 7b18ee1

Browse files
author
Robin Chalas
committed
[Messenger] Restore message handlers laziness
1 parent 5661c41 commit 7b18ee1

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

DependencyInjection/FrameworkExtension.php

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@
3737
use Symfony\Component\Console\Command\Command;
3838
use Symfony\Component\DependencyInjection\Alias;
3939
use Symfony\Component\DependencyInjection\Argument\IteratorArgument;
40-
use Symfony\Component\DependencyInjection\Argument\RewindableGenerator;
4140
use Symfony\Component\DependencyInjection\Argument\ServiceClosureArgument;
4241
use Symfony\Component\DependencyInjection\ChildDefinition;
4342
use Symfony\Component\DependencyInjection\ContainerBuilder;
@@ -1600,12 +1599,7 @@ private function registerMessengerConfiguration(array $config, ContainerBuilder
16001599
$senders[$sender] = new Reference($senderAliases[$sender] ?? $sender);
16011600
}
16021601

1603-
$sendersId = 'messenger.senders.'.$message;
1604-
$container->register($sendersId, RewindableGenerator::class)
1605-
->setFactory('current')
1606-
->addArgument(array(new IteratorArgument($senders)));
1607-
$messageToSendersMapping[$message] = new Reference($sendersId);
1608-
1602+
$messageToSendersMapping[$message] = new IteratorArgument($senders);
16091603
$messagesToSendAndHandle[$message] = $messageConfiguration['send_and_handle'];
16101604
}
16111605

Tests/DependencyInjection/FrameworkExtensionTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -651,10 +651,11 @@ public function testMessengerRouting()
651651
);
652652

653653
$this->assertSame($messageToSendAndHandleMapping, $senderLocatorDefinition->getArgument(1));
654+
$sendersMapping = $senderLocatorDefinition->getArgument(0);
654655
$this->assertEquals(array(
655656
'amqp' => new Reference('messenger.transport.amqp'),
656657
'audit' => new Reference('audit'),
657-
), $container->getDefinition('messenger.senders.'.DummyMessage::class)->getArgument(0)[0]->getValues());
658+
), $sendersMapping[DummyMessage::class]->getValues());
658659
}
659660

660661
/**

0 commit comments

Comments
 (0)