Migrate to static data providers using rector/rector

OskarStark · nicolas-grekas · commit 737cb97290de · 2023-02-14T09:03:56.000+01:00
diff --git a/Tests/CacheWarmer/SerializerCacheWarmerTest.php b/Tests/CacheWarmer/SerializerCacheWarmerTest.php
@@ -40,7 +40,7 @@ public function testWarmUp(array $loaders)
         $this->assertTrue($arrayPool->getItem('Symfony_Bundle_FrameworkBundle_Tests_Fixtures_Serialization_Author')->isHit());
     }
 
-    public function loaderProvider()
+    public static function loaderProvider()
     {
         return [
             [
diff --git a/Tests/Command/CachePoolClearCommandTest.php b/Tests/Command/CachePoolClearCommandTest.php
@@ -44,7 +44,7 @@ public function testComplete(array $input, array $expectedSuggestions)
         $this->assertSame($expectedSuggestions, $suggestions);
     }
 
-    public function provideCompletionSuggestions()
+    public static function provideCompletionSuggestions()
     {
         yield 'pool_name' => [
             ['f'],
diff --git a/Tests/Command/CachePoolDeleteCommandTest.php b/Tests/Command/CachePoolDeleteCommandTest.php
@@ -98,7 +98,7 @@ public function testComplete(array $input, array $expectedSuggestions)
         $this->assertSame($expectedSuggestions, $suggestions);
     }
 
-    public function provideCompletionSuggestions()
+    public static function provideCompletionSuggestions()
     {
         yield 'pool_name' => [
             ['f'],
diff --git a/Tests/Command/EventDispatcherDebugCommandTest.php b/Tests/Command/EventDispatcherDebugCommandTest.php
@@ -31,7 +31,7 @@ public function testComplete(array $input, array $expectedSuggestions)
         $this->assertSame($expectedSuggestions, $suggestions);
     }
 
-    public function provideCompletionSuggestions()
+    public static function provideCompletionSuggestions()
     {
         yield 'event' => [[''], ['Symfony\Component\Mailer\Event\MessageEvent', 'console.command']];
         yield 'event for other dispatcher' => [['--dispatcher', 'other_event_dispatcher', ''], ['other_event', 'App\OtherEvent']];
diff --git a/Tests/Command/SecretsRemoveCommandTest.php b/Tests/Command/SecretsRemoveCommandTest.php
@@ -37,7 +37,7 @@ public function testComplete(bool $withLocalVault, array $input, array $expected
         $this->assertSame($expectedSuggestions, $suggestions);
     }
 
-    public function provideCompletionSuggestions()
+    public static function provideCompletionSuggestions()
     {
         yield 'name' => [true, [''], ['SECRET', 'OTHER_SECRET']];
         yield '--local name (with local vault)' => [true, ['--local', ''], ['SECRET']];
diff --git a/Tests/Command/SecretsSetCommandTest.php b/Tests/Command/SecretsSetCommandTest.php
@@ -32,7 +32,7 @@ public function testComplete(array $input, array $expectedSuggestions)
         $this->assertSame($expectedSuggestions, $suggestions);
     }
 
-    public function provideCompletionSuggestions()
+    public static function provideCompletionSuggestions()
     {
         yield 'name' => [[''], ['SECRET', 'OTHER_SECRET']];
         yield '--local name (with local vault)' => [['--local', ''], ['SECRET', 'OTHER_SECRET']];
diff --git a/Tests/Command/TranslationDebugCommandTest.php b/Tests/Command/TranslationDebugCommandTest.php
@@ -269,7 +269,7 @@ function ($path, $catalogue) use ($extractedMessagesWithDomains) {
         $this->assertSame($expectedSuggestions, $suggestions);
     }
 
-    public function provideCompletionSuggestions()
+    public static function provideCompletionSuggestions()
     {
         yield 'locale' => [
             [''],
diff --git a/Tests/Command/TranslationUpdateCommandCompletionTest.php b/Tests/Command/TranslationUpdateCommandCompletionTest.php
@@ -42,7 +42,7 @@ public function testComplete(array $input, array $expectedSuggestions)
         $this->assertSame($expectedSuggestions, $suggestions);
     }
 
-    public function provideCompletionSuggestions()
+    public static function provideCompletionSuggestions()
     {
         $bundle = new ExtensionPresentBundle();
 
diff --git a/Tests/Command/WorkflowDumpCommandTest.php b/Tests/Command/WorkflowDumpCommandTest.php
@@ -31,7 +31,7 @@ public function testComplete(array $input, array $expectedSuggestions)
         $this->assertSame($expectedSuggestions, $suggestions);
     }
 
-    public function provideCompletionSuggestions(): iterable
+    public static function provideCompletionSuggestions(): iterable
     {
         yield 'option --dump-format' => [['--dump-format', ''], ['puml', 'mermaid', 'dot']];
     }
diff --git a/Tests/Controller/RedirectControllerTest.php b/Tests/Controller/RedirectControllerTest.php
@@ -103,7 +103,7 @@ public function testRoute($permanent, $keepRequestMethod, $keepQueryParams, $ign
         $this->assertEquals($expectedCode, $returnResponse->getStatusCode());
     }
 
-    public function provider()
+    public static function provider()
     {
         return [
             [true, false, false, false, 301, ['additional-parameter' => 'value']],
@@ -210,7 +210,7 @@ public function testUrlRedirectDefaultPorts()
         $this->assertRedirectUrl($returnValue, $expectedUrl);
     }
 
-    public function urlRedirectProvider()
+    public static function urlRedirectProvider()
     {
         return [
             // Standard ports
@@ -262,7 +262,7 @@ public function testUrlRedirect($scheme, $httpPort, $httpsPort, $requestScheme,
         $this->assertRedirectUrl($returnValue, $expectedUrl);
     }
 
-    public function pathQueryParamsProvider()
+    public static function pathQueryParamsProvider()
     {
         return [
             ['http://www.example.com/base/redirect-path', '/redirect-path',  ''],
diff --git a/Tests/DependencyInjection/Compiler/DataCollectorTranslatorPassTest.php b/Tests/DependencyInjection/Compiler/DataCollectorTranslatorPassTest.php
@@ -65,7 +65,7 @@ public function testProcessKeepsDataCollectorIfTranslatorImplementsTranslatorBag
         $this->assertTrue($this->container->hasDefinition('data_collector.translation'));
     }
 
-    public function getImplementingTranslatorBagInterfaceTranslatorClassNames()
+    public static function getImplementingTranslatorBagInterfaceTranslatorClassNames()
     {
         return [
             ['Symfony\Component\Translation\Translator'],
@@ -97,7 +97,7 @@ public function testProcessRemovesDataCollectorIfTranslatorDoesNotImplementTrans
         $this->assertFalse($this->container->hasDefinition('data_collector.translation'));
     }
 
-    public function getNotImplementingTranslatorBagInterfaceTranslatorClassNames()
+    public static function getNotImplementingTranslatorBagInterfaceTranslatorClassNames()
     {
         return [
             ['Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection\Compiler\TranslatorWithTranslatorBag'],
diff --git a/Tests/DependencyInjection/Compiler/ProfilerPassTest.php b/Tests/DependencyInjection/Compiler/ProfilerPassTest.php
@@ -62,7 +62,7 @@ public function testValidCollector()
         $this->assertEquals('add', $methodCalls[0][0]); // grab the method part of the first call
     }
 
-    public function provideValidCollectorWithTemplateUsingAutoconfigure(): \Generator
+    public static function provideValidCollectorWithTemplateUsingAutoconfigure(): \Generator
     {
         yield [new class() implements TemplateAwareDataCollectorInterface {
             public function collect(Request $request, Response $response, \Throwable $exception = null)
diff --git a/Tests/DependencyInjection/ConfigurationTest.php b/Tests/DependencyInjection/ConfigurationTest.php
@@ -60,7 +60,7 @@ public function testInvalidSessionName($sessionName)
         );
     }
 
-    public function getTestInvalidSessionName()
+    public static function getTestInvalidSessionName()
     {
         return [
             ['a.b'],
@@ -113,7 +113,7 @@ public function testValidAssetsPackageNameConfiguration($packageName)
         $this->assertArrayHasKey($packageName, $config['assets']['packages']);
     }
 
-    public function provideValidAssetsPackageNameConfigurationTests()
+    public static function provideValidAssetsPackageNameConfigurationTests()
     {
         return [
             ['foobar'],
@@ -139,7 +139,7 @@ public function testInvalidAssetsConfiguration(array $assetConfig, $expectedMess
             ]);
     }
 
-    public function provideInvalidAssetConfigurationTests()
+    public static function provideInvalidAssetConfigurationTests()
     {
         // helper to turn config into embedded package config
         $createPackageConfig = function (array $packageConfig) {
@@ -192,7 +192,7 @@ public function testValidLockConfiguration($lockConfig, $processedConfig)
         $this->assertEquals($processedConfig, $config['lock']);
     }
 
-    public function provideValidLockConfigurationTests()
+    public static function provideValidLockConfigurationTests()
     {
         yield [null, ['enabled' => true, 'resources' => ['default' => [class_exists(SemaphoreStore::class) && SemaphoreStore::isSupported() ? 'semaphore' : 'flock']]]];
 
diff --git a/Tests/DependencyInjection/FrameworkExtensionTestCase.php b/Tests/DependencyInjection/FrameworkExtensionTestCase.php
@@ -1751,7 +1751,7 @@ public function testAppRedisTagAwareAdapter(string $configFile)
         }
     }
 
-    public function appRedisTagAwareConfigProvider(): array
+    public static function appRedisTagAwareConfigProvider(): array
     {
         return [
             ['cache_app_redis_tag_aware'],
@@ -1930,7 +1930,7 @@ public function testHttpClientFullDefaultOptions()
         ], $defaultOptions['peer_fingerprint']);
     }
 
-    public function provideMailer(): array
+    public static function provideMailer(): array
     {
         return [
             ['mailer_with_dsn', ['main' => 'smtp://example.com']],
diff --git a/Tests/Functional/AnnotatedControllerTest.php b/Tests/Functional/AnnotatedControllerTest.php
@@ -29,7 +29,7 @@ public function testAnnotatedController($path, $expectedValue)
         $this->assertSame('/annotated/create-transaction', $router->generate('symfony_framework_tests_functional_test_annotated_createtransaction'));
     }
 
-    public function getRoutes()
+    public static function getRoutes()
     {
         return [
             ['/null_request', 'Symfony\Component\HttpFoundation\Request'],
diff --git a/Tests/Functional/ConfigDebugCommandTest.php b/Tests/Functional/ConfigDebugCommandTest.php
@@ -138,7 +138,7 @@ public function testComplete(array $input, array $expectedSuggestions)
         }
     }
 
-    public function provideCompletionSuggestions(): \Generator
+    public static function provideCompletionSuggestions(): \Generator
     {
         yield 'name' => [[''], ['default_config_test', 'extension_without_config_test', 'framework', 'test']];
 
diff --git a/Tests/Functional/ConfigDumpReferenceCommandTest.php b/Tests/Functional/ConfigDumpReferenceCommandTest.php
@@ -103,7 +103,7 @@ public function testComplete(array $input, array $expectedSuggestions)
         $this->assertSame($expectedSuggestions, $suggestions);
     }
 
-    public function provideCompletionSuggestions(): iterable
+    public static function provideCompletionSuggestions(): iterable
     {
         yield 'name' => [[''], ['DefaultConfigTestBundle', 'default_config_test', 'ExtensionWithoutConfigTestBundle', 'extension_without_config_test', 'FrameworkBundle', 'framework', 'TestBundle', 'test']];
         yield 'option --format' => [['--format', ''], ['yaml', 'xml']];
diff --git a/Tests/Functional/ContainerDebugCommandTest.php b/Tests/Functional/ContainerDebugCommandTest.php
@@ -204,7 +204,7 @@ public function testGetDeprecationNoFile()
         $this->assertStringContainsString('[WARNING] The deprecation file does not exist', $tester->getDisplay());
     }
 
-    public function provideIgnoreBackslashWhenFindingService()
+    public static function provideIgnoreBackslashWhenFindingService()
     {
         return [
             [BackslashClass::class],
@@ -232,7 +232,7 @@ public function testComplete(array $input, array $expectedSuggestions, array $no
         }
     }
 
-    public function provideCompletionSuggestions()
+    public static function provideCompletionSuggestions()
     {
         $serviceId = 'console.command.container_debug';
         $hiddenServiceId = '.console.command.container_debug.lazy';
diff --git a/Tests/Functional/DebugAutowiringCommandTest.php b/Tests/Functional/DebugAutowiringCommandTest.php
@@ -129,7 +129,7 @@ public function testComplete(array $input, array $expectedSuggestions)
         }
     }
 
-    public function provideCompletionSuggestions(): \Generator
+    public static function provideCompletionSuggestions(): \Generator
     {
         yield 'search' => [[''], ['SessionHandlerInterface', 'Psr\\Log\\LoggerInterface', 'Psr\\Container\\ContainerInterface $parameterBag']];
     }
diff --git a/Tests/Functional/FragmentTest.php b/Tests/Functional/FragmentTest.php
@@ -37,7 +37,7 @@ public function testFragment($insulate)
             , $client->getResponse()->getContent());
     }
 
-    public function getConfigs()
+    public static function getConfigs()
     {
         return [
             [false],
diff --git a/Tests/Functional/ProfilerTest.php b/Tests/Functional/ProfilerTest.php
@@ -57,7 +57,7 @@ public function testProfilerCollectParameter($insulate)
         $this->assertNull($client->getProfile());
     }
 
-    public function getConfigs()
+    public static function getConfigs()
     {
         return [
             [false],
diff --git a/Tests/Functional/RouterDebugCommandTest.php b/Tests/Functional/RouterDebugCommandTest.php
@@ -100,7 +100,7 @@ public function testComplete(array $input, array $expectedSuggestions)
         $this->assertSame($expectedSuggestions, $tester->complete($input));
     }
 
-    public function provideCompletionSuggestions()
+    public static function provideCompletionSuggestions()
     {
         yield 'option --format' => [
             ['--format', ''],
diff --git a/Tests/Functional/SecurityTest.php b/Tests/Functional/SecurityTest.php
@@ -33,7 +33,7 @@ public function testLoginUser(string $username, array $roles, ?string $firewallC
         $this->assertEquals('Welcome '.$username.'!', $client->getResponse()->getContent());
     }
 
-    public function getUsers()
+    public static function getUsers()
     {
         yield ['the-username', ['ROLE_FOO'], null];
         yield ['the-username', ['ROLE_FOO'], 'main'];
diff --git a/Tests/Functional/SerializerTest.php b/Tests/Functional/SerializerTest.php
@@ -52,7 +52,7 @@ public function testNormalizersAndEncodersUseDefaultContextConfigOption(string $
         self::assertEquals('foo', $defaultContext['fake_context_option']);
     }
 
-    public function provideNormalizersAndEncodersWithDefaultContextOption(): array
+    public static function provideNormalizersAndEncodersWithDefaultContextOption(): array
     {
         return [
             ['serializer.normalizer.constraint_violation_list.alias'],
diff --git a/Tests/Functional/SessionTest.php b/Tests/Functional/SessionTest.php
@@ -194,7 +194,7 @@ public function testCorrectCacheControlHeadersForCacheableAction($config, $insul
         $this->assertSame('public, s-maxage=100', $response->headers->get('cache-control'));
     }
 
-    public function getConfigs()
+    public static function getConfigs()
     {
         return [
             // configfile, insulate
diff --git a/Tests/Routing/RouterTest.php b/Tests/Routing/RouterTest.php
@@ -511,7 +511,7 @@ public function testBooleanContainerParametersWithinRouteCondition()
         $this->assertSame('1 or 0', $route->getCondition());
     }
 
-    public function getNonStringValues()
+    public static function getNonStringValues()
     {
         return [[null], [false], [true], [new \stdClass()], [['foo', 'bar']], [[[]]]];
     }
@@ -591,7 +591,7 @@ public function testResolvingMethods()
         $this->assertEquals(['GET', 'POST'], $route->getMethods());
     }
 
-    public function getContainerParameterForRoute()
+    public static function getContainerParameterForRoute()
     {
         yield 'String' => ['"foo"'];
         yield 'Integer' => [0];
diff --git a/Tests/Translation/TranslatorTest.php b/Tests/Translation/TranslatorTest.php
@@ -177,7 +177,7 @@ public function testResourceFilesOptionLoadsBeforeOtherAddedResources($debug, $e
         $translator->trans('some_message', [], null, 'some_locale');
     }
 
-    public function getDebugModeAndCacheDirCombinations()
+    public static function getDebugModeAndCacheDirCombinations()
     {
         return [
             [false, false],

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ public function testWarmUp(array $loaders)`
`40`	`40`	`$this->assertTrue($arrayPool->getItem('Symfony_Bundle_FrameworkBundle_Tests_Fixtures_Serialization_Author')->isHit());`
`41`	`41`	`}`
`42`	`42`
`43`		`- public function loaderProvider()`
	`43`	`+ public static function loaderProvider()`
`44`	`44`	`{`
`45`	`45`	`return [`
`46`	`46`	`[`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ public function testComplete(array $input, array $expectedSuggestions)`
`44`	`44`	`$this->assertSame($expectedSuggestions, $suggestions);`
`45`	`45`	`}`
`46`	`46`
`47`		`- public function provideCompletionSuggestions()`
	`47`	`+ public static function provideCompletionSuggestions()`
`48`	`48`	`{`
`49`	`49`	`yield 'pool_name' => [`
`50`	`50`	`['f'],`
Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ public function testComplete(array $input, array $expectedSuggestions)`
`98`	`98`	`$this->assertSame($expectedSuggestions, $suggestions);`
`99`	`99`	`}`
`100`	`100`
`101`		`- public function provideCompletionSuggestions()`
	`101`	`+ public static function provideCompletionSuggestions()`
`102`	`102`	`{`
`103`	`103`	`yield 'pool_name' => [`
`104`	`104`	`['f'],`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ public function testComplete(array $input, array $expectedSuggestions)`
`31`	`31`	`$this->assertSame($expectedSuggestions, $suggestions);`
`32`	`32`	`}`
`33`	`33`
`34`		`- public function provideCompletionSuggestions()`
	`34`	`+ public static function provideCompletionSuggestions()`
`35`	`35`	`{`
`36`	`36`	`yield 'event' => [[''], ['Symfony\Component\Mailer\Event\MessageEvent', 'console.command']];`
`37`	`37`	`yield 'event for other dispatcher' => [['--dispatcher', 'other_event_dispatcher', ''], ['other_event', 'App\OtherEvent']];`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ public function testComplete(bool $withLocalVault, array $input, array $expected`
`37`	`37`	`$this->assertSame($expectedSuggestions, $suggestions);`
`38`	`38`	`}`
`39`	`39`
`40`		`- public function provideCompletionSuggestions()`
	`40`	`+ public static function provideCompletionSuggestions()`
`41`	`41`	`{`
`42`	`42`	`yield 'name' => [true, [''], ['SECRET', 'OTHER_SECRET']];`
`43`	`43`	`yield '--local name (with local vault)' => [true, ['--local', ''], ['SECRET']];`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ public function testComplete(array $input, array $expectedSuggestions)`
`32`	`32`	`$this->assertSame($expectedSuggestions, $suggestions);`
`33`	`33`	`}`
`34`	`34`
`35`		`- public function provideCompletionSuggestions()`
	`35`	`+ public static function provideCompletionSuggestions()`
`36`	`36`	`{`
`37`	`37`	`yield 'name' => [[''], ['SECRET', 'OTHER_SECRET']];`
`38`	`38`	`yield '--local name (with local vault)' => [['--local', ''], ['SECRET', 'OTHER_SECRET']];`
Original file line number	Diff line number	Diff line change
`@@ -269,7 +269,7 @@ function ($path, $catalogue) use ($extractedMessagesWithDomains) {`
`269`	`269`	`$this->assertSame($expectedSuggestions, $suggestions);`
`270`	`270`	`}`
`271`	`271`
`272`		`- public function provideCompletionSuggestions()`
	`272`	`+ public static function provideCompletionSuggestions()`
`273`	`273`	`{`
`274`	`274`	`yield 'locale' => [`
`275`	`275`	`[''],`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ public function testComplete(array $input, array $expectedSuggestions)`
`42`	`42`	`$this->assertSame($expectedSuggestions, $suggestions);`
`43`	`43`	`}`
`44`	`44`
`45`		`- public function provideCompletionSuggestions()`
	`45`	`+ public static function provideCompletionSuggestions()`
`46`	`46`	`{`
`47`	`47`	`$bundle = new ExtensionPresentBundle();`
`48`	`48`
Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ public function testRoute($permanent, $keepRequestMethod, $keepQueryParams, $ign`
`103`	`103`	`$this->assertEquals($expectedCode, $returnResponse->getStatusCode());`
`104`	`104`	`}`
`105`	`105`
`106`		`- public function provider()`
	`106`	`+ public static function provider()`
`107`	`107`	`{`
`108`	`108`	`return [`
`109`	`109`	`[true, false, false, false, 301, ['additional-parameter' => 'value']],`
`@@ -210,7 +210,7 @@ public function testUrlRedirectDefaultPorts()`
`210`	`210`	`$this->assertRedirectUrl($returnValue, $expectedUrl);`
`211`	`211`	`}`
`212`	`212`
`213`		`- public function urlRedirectProvider()`
	`213`	`+ public static function urlRedirectProvider()`
`214`	`214`	`{`
`215`	`215`	`return [`
`216`	`216`	`// Standard ports`
`@@ -262,7 +262,7 @@ public function testUrlRedirect($scheme, $httpPort, $httpsPort, $requestScheme,`
`262`	`262`	`$this->assertRedirectUrl($returnValue, $expectedUrl);`
`263`	`263`	`}`
`264`	`264`
`265`		`- public function pathQueryParamsProvider()`
	`265`	`+ public static function pathQueryParamsProvider()`
`266`	`266`	`{`
`267`	`267`	`return [`
`268`	`268`	`['http://www.example.com/base/redirect-path', '/redirect-path', ''],`