Skip to content

Commit 55e83bc

Browse files
Merge branch '3.0'
* 3.0: [Process] Fix potential race condition [PhpUnitBridge] Re-enable the garbage collector typo [FrameworkBundle] Allow to autowire service_container [FrameworkBundle] Set the kernel.name properly after a cache warmup Fix toolbar display when nvd3 is loaded on page Removed spaces before semicolon cast arrays to objects after parsing has finished
2 parents 778681c + 1df5638 commit 55e83bc

File tree

3 files changed

+16
-4
lines changed

3 files changed

+16
-4
lines changed

Command/CacheClearCommand.php

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -164,9 +164,18 @@ protected function warmup($warmupDir, $realCacheDir, $enableOptionalWarmers = tr
164164
}
165165

166166
// fix references to kernel/container related classes
167-
$search = $tempKernel->getName().ucfirst($tempKernel->getEnvironment());
168-
$replace = $realKernel->getName().ucfirst($realKernel->getEnvironment());
169-
foreach (Finder::create()->files()->name($search.'*')->in($warmupDir) as $file) {
167+
$fileSearch = $tempKernel->getName().ucfirst($tempKernel->getEnvironment()).'*';
168+
$search = array(
169+
$tempKernel->getName().ucfirst($tempKernel->getEnvironment()),
170+
sprintf('\'kernel.name\' => \'%s\'', $tempKernel->getName()),
171+
sprintf('key="kernel.name">%s<', $tempKernel->getName()),
172+
);
173+
$replace = array(
174+
$realKernel->getName().ucfirst($realKernel->getEnvironment()),
175+
sprintf('\'kernel.name\' => \'%s\'', $realKernel->getName()),
176+
sprintf('key="kernel.name">%s<', $realKernel->getName()),
177+
);
178+
foreach (Finder::create()->files()->name($fileSearch)->in($warmupDir) as $file) {
170179
$content = str_replace($search, $replace, file_get_contents($file));
171180
file_put_contents(str_replace($search, $replace, $file), $content);
172181
unlink($file);

Resources/config/services.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,9 @@
2929
<argument type="collection" />
3030
</service>
3131

32-
<service id="service_container" synthetic="true" />
32+
<service id="service_container" synthetic="true">
33+
<autowiring-type>Symfony\Component\DependencyInjection\ContainerInterface</autowiring-type>
34+
</service>
3335

3436
<service id="kernel" synthetic="true" />
3537

Tests/Command/CacheClearCommand/CacheClearCommandTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,5 +81,6 @@ public function testCacheIsFreshAfterCacheClearedWithWarmup()
8181
}
8282
}
8383
$this->assertTrue($found, 'Kernel file should present as resource');
84+
$this->assertRegExp(sprintf('/\'kernel.name\'\s*=>\s*\'%s\'/', $this->kernel->getName()), file_get_contents($containerFile), 'kernel.name is properly set on the dumped container');
8485
}
8586
}

0 commit comments

Comments
 (0)