Skip to content

Commit 4db6ec2

Browse files
Merge branch '2.7' into 2.8
* 2.7: `@throws` annotations should go after `@return` Fix merge updated VERSION for 2.3.42 update CONTRIBUTORS for 2.3.42 updated CHANGELOG for 2.3.42 Revert "bug #18908 [DependencyInjection] force enabling the external XML entity loaders (xabbuh)" Partial revert of previous PR [DependencyInjection] Skip deep reference check for 'service_container' Catch \Throwable [Serializer] Add missing @throws annotations Fix for #18843 force enabling the external XML entity loaders Removed UTC specification with timestamp Conflicts: src/Symfony/Component/DependencyInjection/Tests/Dumper/PhpDumperTest.php src/Symfony/Component/Finder/Finder.php src/Symfony/Component/Security/Acl/Dbal/MutableAclProvider.php src/Symfony/Component/Security/Acl/Domain/ObjectIdentity.php src/Symfony/Component/Security/Acl/Model/AclInterface.php src/Symfony/Component/Security/Acl/Model/MutableAclProviderInterface.php src/Symfony/Component/Security/Acl/Permission/MaskBuilder.php src/Symfony/Component/Translation/Loader/XliffFileLoader.php src/Symfony/Component/Yaml/Tests/InlineTest.php
2 parents 72150c7 + b0d0106 commit 4db6ec2

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

Routing/DelegatingLoader.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,9 @@ public function load($resource, $type = null)
8484
} catch (\Exception $e) {
8585
$this->loading = false;
8686
throw $e;
87+
} catch (\Throwable $e) {
88+
$this->loading = false;
89+
throw $e;
8790
}
8891

8992
$this->loading = false;
@@ -92,7 +95,7 @@ public function load($resource, $type = null)
9295
if ($controller = $route->getDefault('_controller')) {
9396
try {
9497
$controller = $this->parser->parse($controller);
95-
} catch (\Exception $e) {
98+
} catch (\InvalidArgumentException $e) {
9699
// unable to optimize unknown notation
97100
}
98101

Translation/PhpExtractor.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,9 +182,9 @@ protected function parseTokens($tokens, MessageCatalogue $catalog)
182182
/**
183183
* @param string $file
184184
*
185-
* @throws \InvalidArgumentException
186-
*
187185
* @return bool
186+
*
187+
* @throws \InvalidArgumentException
188188
*/
189189
protected function canBeExtracted($file)
190190
{

0 commit comments

Comments
 (0)