Skip to content

Commit 44b453d

Browse files
Merge branch '6.2' into 6.3
* 6.2: fix merge [DependencyInjection] Filter "container.excluded" services when using `findTaggedServiceIds()` [Cache] Removing null coalescing assignment operator on 5.4 [Console] Add missing ZSH mention in DumpCompletionCommand help [Cache] Fix storing binary keys when using pgsql [FrameworkBundle] Add missing monolog channel tag for messenger services update documentation for telegram bridge notifier [FrameworkBundle] Improve documentation about translation:extract --sort option [VarDumper] Disable links for IntelliJ platform [Notifier] Add bridge documentation [HttpClient] Add hint about `timeout` and `max_duration` options [HttpFoundation] Use separate caches for IpUtils checkIp4 and checkIp6 [FrameworkBundle] Fix wiring session.handler when handler_id is null [FrameworkBundle] Workflow - Fix LogicException about a wrong configuration of "enabled" node
2 parents 43d6c9f + 1b4d7a6 commit 44b453d

File tree

6 files changed

+13
-11
lines changed

6 files changed

+13
-11
lines changed

Command/TranslationUpdateCommand.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ protected function configure(): void
8787
new InputOption('force', null, InputOption::VALUE_NONE, 'Should the extract be done'),
8888
new InputOption('clean', null, InputOption::VALUE_NONE, 'Should clean not found messages'),
8989
new InputOption('domain', null, InputOption::VALUE_OPTIONAL, 'Specify the domain to extract'),
90-
new InputOption('sort', null, InputOption::VALUE_OPTIONAL, 'Return list of messages sorted alphabetically', 'asc'),
90+
new InputOption('sort', null, InputOption::VALUE_OPTIONAL, 'Return list of messages sorted alphabetically (only works with --dump-messages)', 'asc'),
9191
new InputOption('as-tree', null, InputOption::VALUE_OPTIONAL, 'Dump the messages as a tree-like structure: The given value defines the level where to switch to inline YAML'),
9292
])
9393
->setHelp(<<<'EOF'
@@ -116,7 +116,6 @@ protected function configure(): void
116116
You can dump a tree-like structure using the yaml format with <comment>--as-tree</> flag:
117117
118118
<info>php %command.full_name% --force --format=yaml --as-tree=3 en AcmeBundle</info>
119-
<info>php %command.full_name% --force --format=yaml --sort=asc --as-tree=3 fr</info>
120119

121120
EOF
122121
)

DependencyInjection/Configuration.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,7 @@ private function addWorkflowSection(ArrayNodeDefinition $rootNode): void
366366

367367
foreach ($workflows as $key => $workflow) {
368368
if (isset($workflow['enabled']) && false === $workflow['enabled']) {
369-
throw new LogicException(sprintf('Cannot disable a single workflow. Remove the configuration for the workflow "%s" instead.', $workflow['name']));
369+
throw new LogicException(sprintf('Cannot disable a single workflow. Remove the configuration for the workflow "%s" instead.', $key));
370370
}
371371

372372
unset($workflows[$key]['enabled']);

DependencyInjection/FrameworkExtension.php

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1233,11 +1233,8 @@ private function registerSessionConfiguration(array $config, ContainerBuilder $c
12331233

12341234
// session handler (the internal callback registered with PHP session management)
12351235
if (null === $config['handler_id']) {
1236-
// Set the handler class to be null
1237-
$container->getDefinition('session.storage.factory.native')->replaceArgument(1, null);
1238-
$container->getDefinition('session.storage.factory.php_bridge')->replaceArgument(0, null);
1239-
1240-
$container->setAlias('session.handler', 'session.handler.native_file');
1236+
$config['save_path'] = null;
1237+
$container->setAlias('session.handler', 'session.handler.native');
12411238
} else {
12421239
$container->resolveEnvPlaceholders($config['handler_id'], null, $usedEnvs);
12431240

Resources/config/messenger.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,7 @@
143143
->args([
144144
service('logger')->ignoreOnInvalid(),
145145
])
146+
->tag('monolog.logger', ['channel' => 'messenger'])
146147

147148
->set('messenger.transport.beanstalkd.factory', BeanstalkdTransportFactory::class)
148149

@@ -206,6 +207,7 @@
206207
service('logger')->ignoreOnInvalid(),
207208
])
208209
->tag('kernel.event_subscriber')
210+
->tag('monolog.logger', ['channel' => 'messenger'])
209211

210212
->set('messenger.listener.stop_worker_on_stop_exception_listener', StopWorkerOnCustomStopExceptionListener::class)
211213
->tag('kernel.event_subscriber')

Resources/config/session.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,11 @@
6969

7070
->alias(\SessionHandlerInterface::class, 'session.handler')
7171

72+
->set('session.handler.native', StrictSessionHandler::class)
73+
->args([
74+
inline_service(\SessionHandler::class),
75+
])
76+
7277
->set('session.handler.native_file', StrictSessionHandler::class)
7378
->args([
7479
inline_service(NativeFileSessionHandler::class)

Tests/DependencyInjection/FrameworkExtensionTestCase.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -666,9 +666,8 @@ public function testNullSessionHandler()
666666
{
667667
$container = $this->createContainerFromFile('session');
668668

669-
$this->assertNull($container->getDefinition('session.storage.factory.native')->getArgument(1));
670-
$this->assertNull($container->getDefinition('session.storage.factory.php_bridge')->getArgument(0));
671-
$this->assertSame('session.handler.native_file', (string) $container->getAlias('session.handler'));
669+
$this->assertNull($container->getParameter('session.save_path'));
670+
$this->assertSame('session.handler.native', (string) $container->getAlias('session.handler'));
672671

673672
$expected = ['session_factory', 'logger', 'session_collector'];
674673
$this->assertEquals($expected, array_keys($container->getDefinition('session_listener')->getArgument(0)->getValues()));

0 commit comments

Comments
 (0)