[FrameworkBundle] fix KernelBrowser::loginUser with a stateless firewall

Author: dunglas

KernelBrowser.php

@@ -122,7 +122,15 @@ public function loginUser($user, string $firewallContext = 'main'): self
 
         $token = new TestBrowserToken($user->getRoles(), $user, $firewallContext);
         $token->setAuthenticated(true);
-        $session = $this->getContainer()->get('session');
+
+        $container = $this->getContainer();
+        $container->get('security.token_storage')->setToken($token);
+
+        if (!$container->has('session')) {
+            return $this;
+        }
+
+        $session = $container->get('session');
         $session->set('_security_'.$firewallContext, serialize($token));
         $session->save();
 

Tests/Functional/SecurityTest.php

@@ -38,6 +38,7 @@ public function getUsers()
         yield ['the-username', ['ROLE_FOO'], null];
         yield ['the-username', ['ROLE_FOO'], 'main'];
         yield ['other-username', ['ROLE_FOO'], 'custom'];
+        yield ['stateless-username', ['ROLE_FOO'], 'stateless'];
 
         yield ['the-username', ['ROLE_FOO'], null];
         yield ['no-role-username', [], null];

Tests/Functional/app/Security/config.yml

@@ -12,6 +12,10 @@ security:
             memory:
                 users:
                     other-username: { password: the-password, roles: ['ROLE_FOO'] }
+        stateless:
+            memory:
+                users:
+                    stateless-username: { password: the-password, roles: ['ROLE_FOO'] }
 
     firewalls:
         main:
@@ -24,3 +28,8 @@ security:
             form_login:
                 check_path: /custom/login/check
             provider: custom
+        stateless:
+            pattern: ^/stateless
+            stateless: true
+            http_basic: ~
+            provider: stateless

Tests/Functional/app/Security/routing.yml

@@ -5,3 +5,7 @@ security_profile:
 security_custom_profile:
     path:     /custom/user_profile
     defaults: { _controller: Symfony\Bundle\FrameworkBundle\Tests\Functional\Bundle\TestBundle\Controller\SecurityController::profileAction }
+
+security_stateless_profile:
+    path:     /stateless/user_profile
+    defaults: { _controller: Symfony\Bundle\FrameworkBundle\Tests\Functional\Bundle\TestBundle\Controller\SecurityController::profileAction }