Skip abstract definitions in compiler passes

chalasr · chalasr · commit 32dee2aa948b · 2017-03-17T14:55:48.000+01:00
diff --git a/Tests/DependencyInjection/Compiler/AddConsoleCommandPassTest.php b/Tests/DependencyInjection/Compiler/AddConsoleCommandPassTest.php
@@ -62,10 +62,6 @@ public function visibilityProvider()
         );
     }
 
-    /**
-     * @expectedException \InvalidArgumentException
-     * @expectedExceptionMessage The service "my-command" tagged "console.command" must not be abstract.
-     */
     public function testProcessThrowAnExceptionIfTheServiceIsAbstract()
     {
         $container = new ContainerBuilder();
@@ -77,6 +73,8 @@ public function testProcessThrowAnExceptionIfTheServiceIsAbstract()
         $container->setDefinition('my-command', $definition);
 
         $container->compile();
+
+        $this->assertSame(array(), $container->getParameter('console.command.ids'));
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -62,10 +62,6 @@ public function visibilityProvider()`
`62`	`62`	`);`
`63`	`63`	`}`
`64`	`64`
`65`		`- /**`
`66`		`- * @expectedException \InvalidArgumentException`
`67`		`- * @expectedExceptionMessage The service "my-command" tagged "console.command" must not be abstract.`
`68`		`- */`
`69`	`65`	`public function testProcessThrowAnExceptionIfTheServiceIsAbstract()`
`70`	`66`	`{`
`71`	`67`	`$container = new ContainerBuilder();`
`@@ -77,6 +73,8 @@ public function testProcessThrowAnExceptionIfTheServiceIsAbstract()`
`77`	`73`	`$container->setDefinition('my-command', $definition);`
`78`	`74`
`79`	`75`	`$container->compile();`
	`76`	`+`
	`77`	`+ $this->assertSame(array(), $container->getParameter('console.command.ids'));`
`80`	`78`	`}`
`81`	`79`
`82`	`80`	`/**`