Use is_file() instead of file_exists() where possible

Author: nicolas-grekas

KernelBrowser.php

@@ -198,7 +198,7 @@ protected function getScript($request)
             if (0 === strpos($class, 'ComposerAutoloaderInit')) {
                 $r = new \ReflectionClass($class);
                 $file = \dirname($r->getFileName(), 2).'/autoload.php';
-                if (file_exists($file)) {
+                if (is_file($file)) {
                     $requires .= 'require_once '.var_export($file, true).";\n";
                 }
             }

Secrets/DotenvVault.php

@@ -38,7 +38,7 @@ public function seal(string $name, string $value): void
         $this->validateName($name);
         $v = str_replace("'", "'\\''", $value);
 
-        $content = file_exists($this->dotenvFile) ? file_get_contents($this->dotenvFile) : '';
+        $content = is_file($this->dotenvFile) ? file_get_contents($this->dotenvFile) : '';
         $content = preg_replace("/^$name=((\\\\'|'[^']++')++|.*)/m", "$name='$v'", $content, -1, $count);
 
         if (!$count) {
@@ -70,7 +70,7 @@ public function remove(string $name): bool
         $this->lastMessage = null;
         $this->validateName($name);
 
-        $content = file_exists($this->dotenvFile) ? file_get_contents($this->dotenvFile) : '';
+        $content = is_file($this->dotenvFile) ? file_get_contents($this->dotenvFile) : '';
         $content = preg_replace("/^$name=((\\\\'|'[^']++')++|.*)\n?/m", '', $content, -1, $count);
 
         if ($count) {

Secrets/SodiumVault.php

@@ -58,7 +58,7 @@ public function generateKeys(bool $override = false): bool
             // ignore failures to load keys
         }
 
-        if ('' !== $this->decryptionKey && !file_exists($this->pathPrefix.'encrypt.public.php')) {
+        if ('' !== $this->decryptionKey && !is_file($this->pathPrefix.'encrypt.public.php')) {
             $this->export('encrypt.public', $this->encryptionKey);
         }
 
@@ -99,7 +99,7 @@ public function reveal(string $name): ?string
         $this->lastMessage = null;
         $this->validateName($name);
 
-        if (!file_exists($file = $this->pathPrefix.$name.'.'.substr_replace(md5($name), '.php', -26))) {
+        if (!is_file($file = $this->pathPrefix.$name.'.'.substr_replace(md5($name), '.php', -26))) {
             $this->lastMessage = sprintf('Secret "%s" not found in "%s".', $name, $this->getPrettyPath(\dirname($this->pathPrefix).\DIRECTORY_SEPARATOR));
 
             return null;
@@ -133,7 +133,7 @@ public function remove(string $name): bool
         $this->lastMessage = null;
         $this->validateName($name);
 
-        if (!file_exists($file = $this->pathPrefix.$name.'.'.substr_replace(md5($name), '.php', -26))) {
+        if (!is_file($file = $this->pathPrefix.$name.'.'.substr_replace(md5($name), '.php', -26))) {
             $this->lastMessage = sprintf('Secret "%s" not found in "%s".', $name, $this->getPrettyPath(\dirname($this->pathPrefix).\DIRECTORY_SEPARATOR));
 
             return false;
@@ -152,7 +152,7 @@ public function list(bool $reveal = false): array
     {
         $this->lastMessage = null;
 
-        if (!file_exists($file = $this->pathPrefix.'list.php')) {
+        if (!is_file($file = $this->pathPrefix.'list.php')) {
             return [];
         }
 
@@ -184,11 +184,11 @@ private function loadKeys(): void
             return;
         }
 
-        if (file_exists($this->pathPrefix.'decrypt.private.php')) {
+        if (is_file($this->pathPrefix.'decrypt.private.php')) {
             $this->decryptionKey = (string) include $this->pathPrefix.'decrypt.private.php';
         }
 
-        if (file_exists($this->pathPrefix.'encrypt.public.php')) {
+        if (is_file($this->pathPrefix.'encrypt.public.php')) {
             $this->encryptionKey = (string) include $this->pathPrefix.'encrypt.public.php';
         } elseif ('' !== $this->decryptionKey) {
             $this->encryptionKey = sodium_crypto_box_publickey($this->decryptionKey);