Skip to content

Commit 1cfd505

Browse files
committed
Merge branch '2.7' into 2.8
* 2.7: fixed typo Revert "fixed typo" fixed typo fixed CS Avoid setting request attributes from signature arguments in AnnotationClassLoader [DependencyInjection] Add some missing typehints in YamlFileLoader [DependencyInjection] minor: Fix a DocBlock [HttpKernel] Give higher priority to adding request formats [FrameworkBundle] Fix third level headers for MarkdownDescriptor [TwigBundle] do not lose already set method calls #20411 fix Yaml parsing for very long quoted strings CS: apply is_null DX: remove invalid inheritdoc bumped Symfony version to 2.7.24 updated VERSION for 2.7.23 update CONTRIBUTORS for 2.7.23 updated CHANGELOG for 2.7.23 [FrameworkBundle] Skip test if xdebug.file_link_format is defined.
2 parents 7334658 + 3f49717 commit 1cfd505

File tree

6 files changed

+16
-22
lines changed

6 files changed

+16
-22
lines changed

Console/Descriptor/MarkdownDescriptor.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ protected function describeContainerDefinition(Definition $definition, array $op
245245
}
246246
}
247247

248-
$this->write(isset($options['id']) ? sprintf("%s\n%s\n\n%s\n", $options['id'], str_repeat('~', strlen($options['id'])), $output) : $output);
248+
$this->write(isset($options['id']) ? sprintf("### %s\n\n%s\n", $options['id'], $output) : $output);
249249
}
250250

251251
/**
@@ -256,7 +256,7 @@ protected function describeContainerAlias(Alias $alias, array $options = array()
256256
$output = '- Service: `'.$alias.'`'
257257
."\n".'- Public: '.($alias->isPublic() ? 'yes' : 'no');
258258

259-
$this->write(isset($options['id']) ? sprintf("%s\n%s\n\n%s\n", $options['id'], str_repeat('~', strlen($options['id'])), $output) : $output);
259+
$this->write(isset($options['id']) ? sprintf("### %s\n\n%s\n", $options['id'], $output) : $output);
260260
}
261261

262262
/**

Tests/DependencyInjection/FrameworkExtensionTest.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -326,6 +326,10 @@ public function testAnnotations()
326326

327327
public function testFileLinkFormat()
328328
{
329+
if (ini_get('xdebug.file_link_format') || get_cfg_var('xdebug.file_link_format')) {
330+
$this->markTestSkipped('A custom file_link_format is defined.');
331+
}
332+
329333
$container = $this->createContainerFromFile('full');
330334

331335
$this->assertEquals('file%link%format', $container->getParameter('templating.helper.code.file_link_format'));

Tests/Fixtures/Descriptor/builder_1_public.md

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@ Public services
44
Definitions
55
-----------
66

7-
definition_1
8-
~~~~~~~~~~~~
7+
### definition_1
98

109
- Class: `Full\Qualified\Class1`
1110
- Scope: `container`
@@ -23,14 +22,12 @@ definition_1
2322
Aliases
2423
-------
2524

26-
alias_1
27-
~~~~~~~
25+
### alias_1
2826

2927
- Service: `service_1`
3028
- Public: yes
3129

32-
alias_2
33-
~~~~~~~
30+
### alias_2
3431

3532
- Service: `service_2`
3633
- Public: no

Tests/Fixtures/Descriptor/builder_1_services.md

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@ Public and private services
44
Definitions
55
-----------
66

7-
definition_1
8-
~~~~~~~~~~~~
7+
### definition_1
98

109
- Class: `Full\Qualified\Class1`
1110
- Scope: `container`
@@ -19,8 +18,7 @@ definition_1
1918
- Factory Class: `Full\Qualified\FactoryClass`
2019
- Factory Method: `get`
2120

22-
definition_2
23-
~~~~~~~~~~~~
21+
### definition_2
2422

2523
- Class: `Full\Qualified\Class2`
2624
- Scope: `container`
@@ -45,14 +43,12 @@ definition_2
4543
Aliases
4644
-------
4745

48-
alias_1
49-
~~~~~~~
46+
### alias_1
5047

5148
- Service: `service_1`
5249
- Public: yes
5350

54-
alias_2
55-
~~~~~~~
51+
### alias_2
5652

5753
- Service: `service_2`
5854
- Public: no

Tests/Fixtures/Descriptor/builder_1_tag1.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@ Public and private services with tag `tag1`
44
Definitions
55
-----------
66

7-
definition_2
8-
~~~~~~~~~~~~
7+
### definition_2
98

109
- Class: `Full\Qualified\Class2`
1110
- Scope: `container`

Tests/Fixtures/Descriptor/builder_1_tags.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@ Container tags
44
tag1
55
----
66

7-
definition_2
8-
~~~~~~~~~~~~
7+
### definition_2
98

109
- Class: `Full\Qualified\Class2`
1110
- Scope: `container`
@@ -24,8 +23,7 @@ definition_2
2423
tag2
2524
----
2625

27-
definition_2
28-
~~~~~~~~~~~~
26+
### definition_2
2927

3028
- Class: `Full\Qualified\Class2`
3129
- Scope: `container`

0 commit comments

Comments
 (0)