[DependencyInjection] Fix dumping/loading errored definitions in XML/Yaml

Author: nicolas-grekas

Command/ContainerLintCommand.php

@@ -88,8 +88,6 @@ private function getContainerBuilder(): ContainerBuilder
                 return $this->buildContainer();
             }, $kernel, $kernel::class);
             $container = $buildContainer();
-
-            $skippedIds = [];
         } else {
             if (!$kernelContainer instanceof Container) {
                 throw new RuntimeException(sprintf('This command does not support the application container: "%s" does not extend "%s".', get_debug_type($kernelContainer), Container::class));
@@ -100,13 +98,6 @@ private function getContainerBuilder(): ContainerBuilder
             $refl = new \ReflectionProperty($parameterBag, 'resolved');
             $refl->setValue($parameterBag, true);
 
-            $skippedIds = [];
-            foreach ($container->getServiceIds() as $serviceId) {
-                if (str_starts_with($serviceId, '.errored.')) {
-                    $skippedIds[$serviceId] = true;
-                }
-            }
-
             $container->getCompilerPassConfig()->setBeforeOptimizationPasses([]);
             $container->getCompilerPassConfig()->setOptimizationPasses([]);
             $container->getCompilerPassConfig()->setBeforeRemovingPasses([]);
@@ -115,7 +106,7 @@ private function getContainerBuilder(): ContainerBuilder
         $container->setParameter('container.build_hash', 'lint_container');
         $container->setParameter('container.build_id', 'lint_container');
 
-        $container->addCompilerPass(new CheckTypeDeclarationsPass(true, $skippedIds), PassConfig::TYPE_AFTER_REMOVING, -100);
+        $container->addCompilerPass(new CheckTypeDeclarationsPass(true), PassConfig::TYPE_AFTER_REMOVING, -100);
 
         return $this->containerBuilder = $container;
     }

DependencyInjection/FrameworkExtension.php

@@ -375,13 +375,12 @@ public function load(array $configs, ContainerBuilder $container)
 
             $this->registerSerializerConfiguration($config['serializer'], $container, $loader);
         } else {
-            $container->register('.argument_resolver.request_payload.no_serializer', Serializer::class)
+            $container->getDefinition('argument_resolver.request_payload')
+                ->setArguments([])
                 ->addError('You can neither use "#[MapRequestPayload]" nor "#[MapQueryString]" since the Serializer component is not '
                     .(class_exists(Serializer::class) ? 'enabled. Try setting "framework.serializer" to true.' : 'installed. Try running "composer require symfony/serializer-pack".')
-                );
-
-            $container->getDefinition('argument_resolver.request_payload')
-                ->replaceArgument(0, new Reference('.argument_resolver.request_payload.no_serializer', ContainerInterface::RUNTIME_EXCEPTION_ON_INVALID_REFERENCE))
+                )
+                ->addTag('container.error')
                 ->clearTag('kernel.event_subscriber');
 
             $container->removeDefinition('console.command.serializer_debug');

composer.json

@@ -21,7 +21,7 @@
         "ext-xml": "*",
         "symfony/cache": "^5.4|^6.0",
         "symfony/config": "^6.1",
-        "symfony/dependency-injection": "^6.2.8",
+        "symfony/dependency-injection": "^6.3",
         "symfony/deprecation-contracts": "^2.5|^3",
         "symfony/error-handler": "^6.1",
         "symfony/event-dispatcher": "^5.4|^6.0",