Skip to content

Commit 80fe5eb

Browse files
committed
Clean skippable tests that are never skipped
1 parent 4def7f7 commit 80fe5eb

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

Tests/Html5ParserCrawlerTest.php

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@ public function testAddHtml5()
2929
/** @dataProvider validHtml5Provider */
3030
public function testHtml5ParserParseContentStartingWithValidHeading(string $content)
3131
{
32-
$this->skipTestIfHTML5LibraryNotAvailable();
33-
3432
$crawler = $this->createCrawler();
3533
$crawler->addHtmlContent($content);
3634
self::assertEquals(
@@ -43,8 +41,6 @@ public function testHtml5ParserParseContentStartingWithValidHeading(string $cont
4341
/** @dataProvider invalidHtml5Provider */
4442
public function testHtml5ParserWithInvalidHeadedContent(string $content)
4543
{
46-
$this->skipTestIfHTML5LibraryNotAvailable();
47-
4844
$crawler = $this->createCrawler();
4945
$crawler->addHtmlContent($content);
5046
self::assertEmpty($crawler->filterXPath('//h1')->text(), '->addHtmlContent failed as expected');
@@ -70,11 +66,4 @@ public function invalidHtml5Provider(): iterable
7066
yield 'Text' => ['hello world'.$html];
7167
yield 'Text between comments' => ['<!--c--> test <!--cc-->'.$html];
7268
}
73-
74-
private function skipTestIfHTML5LibraryNotAvailable(): void
75-
{
76-
if (!class_exists(\Masterminds\HTML5::class)) {
77-
self::markTestSkipped('HTML5 library is not available');
78-
}
79-
}
8069
}

0 commit comments

Comments
 (0)