minor #28025 Use an empty string as default for assertEquals (DavidPrevot)

nicolas-grekas · nicolas-grekas · commit 452bfc854b60 · 2018-07-26T12:03:52.000+02:00
This PR was merged into the 3.4 branch.

Discussion
----------

Use an empty string as default for assertEquals

Make sure it isn’t interpreted as a type NULL, making the test fail with PHPUnit 7.2.

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

This shouldn’t break the existing tests, but will also make them work with recent PHPUnit.

Commits
-------

31353147a3 Use an empty string as default for assertEquals
diff --git a/Tests/CrawlerTest.php b/Tests/CrawlerTest.php
@@ -1027,7 +1027,7 @@ public function testParents()
     /**
      * @dataProvider getBaseTagData
      */
-    public function testBaseTag($baseValue, $linkValue, $expectedUri, $currentUri = null, $description = null)
+    public function testBaseTag($baseValue, $linkValue, $expectedUri, $currentUri = null, $description = '')
     {
         $crawler = new Crawler('<html><base href="'.$baseValue.'"><a href="'.$linkValue.'"></a></html>', $currentUri);
         $this->assertEquals($expectedUri, $crawler->filterXPath('//a')->link()->getUri(), $description);

Original file line number	Diff line number	Diff line change
`@@ -1027,7 +1027,7 @@ public function testParents()`
`1027`	`1027`	`/**`
`1028`	`1028`	`* @dataProvider getBaseTagData`
`1029`	`1029`	`*/`
`1030`		`- public function testBaseTag($baseValue, $linkValue, $expectedUri, $currentUri = null, $description = null)`
	`1030`	`+ public function testBaseTag($baseValue, $linkValue, $expectedUri, $currentUri = null, $description = '')`
`1031`	`1031`	`{`
`1032`	`1032`	`$crawler = new Crawler('<html><base href="'.$baseValue.'"><a href="'.$linkValue.'"></a></html>', $currentUri);`
`1033`	`1033`	`$this->assertEquals($expectedUri, $crawler->filterXPath('//a')->link()->getUri(), $description);`