minor #44180 [DomCrawler] Fix HTML5 parser charset option (tgalopin)

nicolas-grekas · nicolas-grekas · commit 42de12bee3b5 · 2021-12-28T15:48:02.000+01:00
This PR was merged into the 4.4 branch.

Discussion
----------

[DomCrawler] Fix HTML5 parser charset option

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Wrong usage of masterminds/html5 options

Commits
-------

53b3e40ab5 [DomCrawler] Fix HTML5 parser charset option
diff --git a/Crawler.php b/Crawler.php
@@ -1186,7 +1186,7 @@ protected function sibling($node, $siblingDir = 'nextSibling')
 
     private function parseHtml5(string $htmlContent, string $charset = 'UTF-8'): \DOMDocument
     {
-        return $this->html5Parser->parse($this->convertToHtmlEntities($htmlContent, $charset), [], $charset);
+        return $this->html5Parser->parse($this->convertToHtmlEntities($htmlContent, $charset));
     }
 
     private function parseXhtml(string $htmlContent, string $charset = 'UTF-8'): \DOMDocument

Original file line number	Diff line number	Diff line change
`@@ -1186,7 +1186,7 @@ protected function sibling($node, $siblingDir = 'nextSibling')`
`1186`	`1186`
`1187`	`1187`	`private function parseHtml5(string $htmlContent, string $charset = 'UTF-8'): \DOMDocument`
`1188`	`1188`	`{`
`1189`		`- return $this->html5Parser->parse($this->convertToHtmlEntities($htmlContent, $charset), [], $charset);`
	`1189`	`+ return $this->html5Parser->parse($this->convertToHtmlEntities($htmlContent, $charset));`
`1190`	`1190`	`}`
`1191`	`1191`
`1192`	`1192`	`private function parseXhtml(string $htmlContent, string $charset = 'UTF-8'): \DOMDocument`