Skip to content

Commit 373eb89

Browse files
committed
minor #24149 [CS] Apply phpdoc_annotation_without_dot (keradus)
This PR was squashed before being merged into the 2.7 branch (closes #24149). Discussion ---------- [CS] Apply phpdoc_annotation_without_dot | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | n/a | Fixed tickets | n/a | License | MIT | Doc PR | n/a Rule was manually applied here : symfony/symfony#19198 In same PR, fixer for this rule was requested, later implementation was approved by Symfony in PHP-CS-Fixer/PHP-CS-Fixer#2020 . Rule is converting single sentence to not a sentence, dropping final dot and lowercasing first word. If there are multiple sentences, it doesn't make any changes. Status quo is that some annotation are in the middle - having first word uppercased, but no final stop. Let us fix grammar by finishing applying the rule. If, for some reason, you don't want to follow that rule that was requested by Symfony, please provide reasoning. If it's to some edge-case bug, simply raise that bug issue. If due to some other reasons, please send a PR to drop it from `@Symfony` ruleset. Info: I did manually reviewed every single change of this PR. Commits ------- 7a97b49436 [CS] Apply phpdoc_annotation_without_dot
2 parents d42d535 + 48eb732 commit 373eb89

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Crawler.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ public function clear()
7171
*
7272
* @param \DOMNodeList|\DOMNode|array|string|null $node A node
7373
*
74-
* @throws \InvalidArgumentException When node is not the expected type.
74+
* @throws \InvalidArgumentException when node is not the expected type
7575
*/
7676
public function add($node)
7777
{

0 commit comments

Comments
 (0)