Skip to content

Commit d17e727

Browse files
committed
[DoctrineBridge][Messenger] Always use executeStatement
1 parent 23a59f7 commit d17e727

File tree

2 files changed

+4
-16
lines changed

2 files changed

+4
-16
lines changed

Security/RememberMe/DoctrineTokenProvider.php

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -76,11 +76,7 @@ public function deleteTokenBySeries(string $series)
7676
$sql = 'DELETE FROM rememberme_token WHERE series=:series';
7777
$paramValues = ['series' => $series];
7878
$paramTypes = ['series' => ParameterType::STRING];
79-
if (method_exists($this->conn, 'executeStatement')) {
80-
$this->conn->executeStatement($sql, $paramValues, $paramTypes);
81-
} else {
82-
$this->conn->executeUpdate($sql, $paramValues, $paramTypes);
83-
}
79+
$this->conn->executeStatement($sql, $paramValues, $paramTypes);
8480
}
8581

8682
/**
@@ -101,11 +97,7 @@ public function updateToken(string $series, #[\SensitiveParameter] string $token
10197
'lastUsed' => Types::DATETIME_IMMUTABLE,
10298
'series' => ParameterType::STRING,
10399
];
104-
if (method_exists($this->conn, 'executeStatement')) {
105-
$updated = $this->conn->executeStatement($sql, $paramValues, $paramTypes);
106-
} else {
107-
$updated = $this->conn->executeUpdate($sql, $paramValues, $paramTypes);
108-
}
100+
$updated = $this->conn->executeStatement($sql, $paramValues, $paramTypes);
109101
if ($updated < 1) {
110102
throw new TokenNotFoundException('No token found.');
111103
}
@@ -131,11 +123,7 @@ public function createNewToken(PersistentTokenInterface $token)
131123
'value' => ParameterType::STRING,
132124
'lastUsed' => Types::DATETIME_IMMUTABLE,
133125
];
134-
if (method_exists($this->conn, 'executeStatement')) {
135-
$this->conn->executeStatement($sql, $paramValues, $paramTypes);
136-
} else {
137-
$this->conn->executeUpdate($sql, $paramValues, $paramTypes);
138-
}
126+
$this->conn->executeStatement($sql, $paramValues, $paramTypes);
139127
}
140128

141129
public function verifyToken(PersistentTokenInterface $token, #[\SensitiveParameter] string $tokenValue): bool

Tests/Security/RememberMe/DoctrineTokenProviderTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ private function bootstrapProvider()
135135
'driver' => 'pdo_sqlite',
136136
'memory' => true,
137137
], $config);
138-
$connection->{method_exists($connection, 'executeStatement') ? 'executeStatement' : 'executeUpdate'}(<<< 'SQL'
138+
$connection->executeStatement(<<< 'SQL'
139139
CREATE TABLE rememberme_token (
140140
series char(88) UNIQUE PRIMARY KEY NOT NULL,
141141
value char(88) NOT NULL,

0 commit comments

Comments
 (0)